pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedjsonlog cursor_position type is wrong.
6+ messages / 4 participants
[nested] [flat]
* jsonlog cursor_position type is wrong.
@ 2022-10-23 22:58 nuko yokohama <nuko.yokohama@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: nuko yokohama @ 2022-10-23 22:58 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hi.
PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
"Type" in cursor_position should be "number", not "Sting".
https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-K...
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: jsonlog cursor_position type is wrong.
@ 2022-10-24 03:24 Tatsuo Ishii <ishii@sraoss.co.jp>
parent: nuko yokohama <nuko.yokohama@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Tatsuo Ishii @ 2022-10-24 03:24 UTC (permalink / raw)
To: nuko.yokohama@gmail.com; +Cc: pgsql-docs@lists.postgresql.org
> Hi.
>
> PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
> "Type" in cursor_position should be "number", not "Sting".
> https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-K...
Yeah, that's a typo. Patch attached.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Attachments:
[text/x-patch] config.patch (487B, ../../20221024.122416.2112506591784053161.t-ishii@sranhm.sra.co.jp/2-config.patch)
download | inline diff:
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 703f6d5a7f..724c832308 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7794,7 +7794,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
</row>
<row>
<entry><literal>cursor_position</literal></entry>
- <entry>string</entry>
+ <entry>number</entry>
<entry>Cursor index into query string</entry>
</row>
<row>
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: jsonlog cursor_position type is wrong.
@ 2022-10-24 04:53 Tom Lane <tgl@sss.pgh.pa.us>
parent: Tatsuo Ishii <ishii@sraoss.co.jp>
0 siblings, 1 reply; 6+ messages in thread
From: Tom Lane @ 2022-10-24 04:53 UTC (permalink / raw)
To: Tatsuo Ishii <ishii@sraoss.co.jp>; +Cc: nuko.yokohama@gmail.com; pgsql-docs@lists.postgresql.org
Tatsuo Ishii <ishii@sraoss.co.jp> writes:
>> PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
>> "Type" in cursor_position should be "number", not "Sting".
>> https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-K...
> Yeah, that's a typo. Patch attached.
Shouldn't it be "integer"?
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: jsonlog cursor_position type is wrong.
@ 2022-10-24 05:04 Michael Paquier <michael@paquier.xyz>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2022-10-24 05:04 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Tatsuo Ishii <ishii@sraoss.co.jp>; nuko.yokohama@gmail.com; pgsql-docs@lists.postgresql.org
On Mon, Oct 24, 2022 at 12:53:26AM -0400, Tom Lane wrote:
> Tatsuo Ishii <ishii@sraoss.co.jp> writes:
>> Yeah, that's a typo. Patch attached.
Thanks, that's wrong :/
> Shouldn't it be "integer"?
When it comes down to the data types of a JSON object, these are
referred as "number", as these can be either integers or floating
points. See:
https://www.w3schools.com/js/js_json_datatypes.asp
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../Y1Yc8MhpkR0SKekj@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: jsonlog cursor_position type is wrong.
@ 2022-10-25 00:31 Michael Paquier <michael@paquier.xyz>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2022-10-25 00:31 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Tatsuo Ishii <ishii@sraoss.co.jp>; nuko.yokohama@gmail.com; pgsql-docs@lists.postgresql.org
On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:
> Thanks, that's wrong :/
Anyway, this one is on me, so applied. Thanks for the patch and the
report!
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../Y1cuR5AaAhbMCccN@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: jsonlog cursor_position type is wrong.
@ 2022-10-25 00:48 Tatsuo Ishii <ishii@sraoss.co.jp>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2022-10-25 00:48 UTC (permalink / raw)
To: michael@paquier.xyz; +Cc: tgl@sss.pgh.pa.us; ishii@sraoss.co.jp; nuko.yokohama@gmail.com; pgsql-docs@lists.postgresql.org
> On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:
>> Thanks, that's wrong :/
>
> Anyway, this one is on me, so applied. Thanks for the patch and the
> report!
Thank you!
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-10-25 00:48 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-10-23 22:58 jsonlog cursor_position type is wrong. nuko yokohama <nuko.yokohama@gmail.com>
2022-10-24 03:24 ` Tatsuo Ishii <ishii@sraoss.co.jp>
2022-10-24 04:53 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-10-24 05:04 ` Michael Paquier <michael@paquier.xyz>
2022-10-25 00:31 ` Michael Paquier <michael@paquier.xyz>
2022-10-25 00:48 ` Tatsuo Ishii <ishii@sraoss.co.jp>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox