Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKVnC-00074k-2I for pgsql-docs@arkaria.postgresql.org; Wed, 25 Jan 2023 02:45:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pKVnA-0007io-8L for pgsql-docs@arkaria.postgresql.org; Wed, 25 Jan 2023 02:45:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKVn9-0007hr-B0 for pgsql-docs@lists.postgresql.org; Wed, 25 Jan 2023 02:45:40 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKVn0-0005kw-Sp for pgsql-docs@lists.postgresql.org; Wed, 25 Jan 2023 02:45:37 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id AEF373200900; Tue, 24 Jan 2023 21:45:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 24 Jan 2023 21:45:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1674614728; x=1674701128; bh=jUtFYPrB5p KqsbfwySlzM5DgdFDBBdmKq7td/7p+Ssg=; b=kut6pdxkmgaC4rnZl9iFGznOhN lo9pZLN5hh1hovDJSayd7UuKDZ2xr7BmxzdnUBVh7a14jpA1/zcmbPDZLIHFNeL4 TcFLMx9I+55mt2FM81imEm/CmVDbfBFCEHz2OwK1jZufJ3TkvBYn4f61qs05qHo3 JKINv0Ftu0S9gwAjmJdI/wPtfgzpBifAKjpVdpcqvteOHZgTMZT2pDHAFfEdXKVR CwdCZ9wTn9TNGRDdSnJQ4FPrvmHA/8iHJezbDdRnW3wt5tFuM40NQ1k3LtsRpzJB S5YpL8SzOl3lIbwF2Kp7hLpDycS6AQyY3lXXd5v5YpdYRxv86nqRKx7Ewt+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674614728; x=1674701128; bh=jUtFYPrB5pKqsbfwySlzM5DgdFDB BdmKq7td/7p+Ssg=; b=lLcMUN9rfN2FN1xdsqZ8YhjrCTYKDlhHHIazgjN/rhAN Sr3TRaSVQwgBQcjf7Opa1oAPUYsX56dlTlsPPjcoxQl0XxCPMPhyJqPdJgQjdJdS MthC3OEvIzen55sZq6qb6IiOzqAJZ/pYzUw2PulozK8tliP6U5dqJTl+8k6D5aXb IL0lI6FrTwnp97f0pjLnC6RN3MSiDygxA3NViZZ/D6o6MT+aE76uYNGu7pgqV22d iu5nrokIfmCeaNv7Gr7UgKwhnQnLo2j1GT7rEyGbucDBo6KvVXQZNHPbcBMS30+L Duv8vuUqPHTES9FNY1Ks/EqArcJ3weCbRG+DasgtuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvuddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Jan 2023 21:45:26 -0500 (EST) Date: Wed, 25 Jan 2023 11:45:22 +0900 From: Michael Paquier To: Tom Lane Cc: greenreaper@hotmail.com, pgsql-docs@lists.postgresql.org Subject: Re: Naming of network_ops vs. inet_ops for SP-GIST Message-ID: References: <167458110639.2667300.14741268666497110766@wrigleys.postgresql.org> <2314977.1674591764@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ir6qfB0sglhSikf2" Content-Disposition: inline In-Reply-To: <2314977.1674591764@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Ir6qfB0sglhSikf2 Content-Type: multipart/mixed; boundary="HLggli43zhBIvFsO" Content-Disposition: inline --HLggli43zhBIvFsO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 24, 2023 at 03:22:44PM -0500, Tom Lane wrote: > I wonder whether we shouldn't just revert this table to > showing opclass names, and avert our eyes from the theoretical > inconsistency. Michael, looks like it was your 7a1cd5260 > that changed it; what do you think? Yes, the docs should be fixed here. The intention is not to show the operator families but the names of the opclasses. I can only spot one difference in SpGiST for network_ops -> inet_ops as of the report. BRIN, GIN and GiST look to be clean after a second lookup. I don't have a strong opinion about the naming inconsistency between the opclass name and the opfamily name in this case, though, couldn't it create more problems than actually fix something? Anyway, attached is a patch for the docs. Thoughts? -- Michael --HLggli43zhBIvFsO Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="spgist-builtin.patch" Content-Transfer-Encoding: quoted-printable diff --git a/doc/src/sgml/spgist.sgml b/doc/src/sgml/spgist.sgml index 00432512de..102f8627bd 100644 --- a/doc/src/sgml/spgist.sgml +++ b/doc/src/sgml/spgist.sgml @@ -91,18 +91,7 @@ |>> (box,box) =20 - kd_point_ops - |>> (point,point) - <-> (point,po= int) - - << (point,point) - >> (point,point) - <<| (point,point) - ~=3D (point,point) - <@ (point,box) - - - network_ops + inet_ops= << (inet,inet) @@ -117,6 +106,17 @@ >=3D (inet,inet) && (inet,inet) =20 + + kd_point_ops + |>> (point,point) + <-> (point,po= int) + + << (point,point) + >> (point,point) + <<| (point,point) + ~=3D (point,point) + <@ (point,box) + poly_ops= << (polygon,polygon) --HLggli43zhBIvFsO-- --Ir6qfB0sglhSikf2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPQl8IACgkQnvQgOdby QH0K3xAAqJwXSxx7kcT97V9RKJX/DnNAeWR4ccbCkxapYl/p3IO0q6bQIrEsNPiZ LH0Zfm4ZhyimAa4Px1XPs1GrnX0FyZ19TOHfvqvbY/RxQOjaRk+1xKdkQzHw7V6c iQDeL1CDI6+W/6ewcb01VqefXAMrf6MVXYHBxvNKti5RCH56dwrKT1p1z0H1UxWY AZO6/p977CFG5a848mXyKliQVv1YURi2VLU2qEy6jM0THxJY/QTaZBzvUd5pl3qp /zkWdzeZEtWEApzGijnjfQ9qrF5uTNuGcHbnCvnCihnDZIXBkYxPeM0uxgDGn87C cELktndTlhaIDJSPQq6aYtGJ5ESREI+qLE+Eaa8flN/VfPC9wxxiN5BSIPC1W80q us444BepcVF6NEuqxBeFtJdolhNT/pQ6auil74qVn35FX12gSuoawW8py4BepNsB QEeuoK0NIo4J2eI9Id8TKnQjE53oulrdjdQ+EkjQL0hRyoJ/xAlOqpQ+kTlVD8Oa MgfcCICp+LcnDRRHu5a8zhO5KBmClgkC+bJLwlRNgH7qDvksP0jhXkepmioJ4Fq7 +cHJJSmRpVIkEZ6++XRGOOKSl59nqpSb63yZRPNFU+7UFg8lgH9wcsSR96PzTWCo vZnFaLWdPwm6TK2wtNx8H0BlYdJAOQxu4QPXijOzSMfcLEUhlsc= =bt1D -----END PGP SIGNATURE----- --Ir6qfB0sglhSikf2--