Date: Wed, 24 Feb 2021 14:49:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: phil@philphonic.de, pgsql-docs@lists.postgresql.org
Subject: Re: incoorect restore_command
Message-ID: <YDXo2tIJmkW6mhkm@paquier.xyz>
References: <161397938841.15451.13129264141285167267@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2+gg6hdGLuxvwKOS"
Content-Disposition: inline
In-Reply-To: <161397938841.15451.13129264141285167267@wrigleys.postgresql.org>
Precedence: bulk


--2+gg6hdGLuxvwKOS
Content-Type: multipart/mixed; boundary="1D1QAIRzwqh4K/03"
Content-Disposition: inline


--1D1QAIRzwqh4K/03
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 22, 2021 at 07:36:28AM +0000, PG Doc comments form wrote:
> I've been trying out saving and restoring compressed archive logs. The
> restore_command stated in the docs at "25.3.6.2. Compressed Archive Logs"
> ('gunzip < /mnt/server/archivedir/%f > %p') did not work for me, because the
> archive_command ('gzip < %p > /var/lib/pgsql/archive/%f') alters the
> filename to %f.gz

On which platform please?  Using a pipe with gzip does not alter the
output file name where the data is pushed to.

> I had to change the restore_command to 'gunzip <
> /mnt/server/archivedir/%f.gz > %p'.

Now, I kind of agree that compressing a file and not using a proper
.gz extension for its name can be confusing.  So what about the
attached to tweak both archive_command and restore_command in this
section of the docs?
--
Michael

--1D1QAIRzwqh4K/03
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="doc-archive-gz.patch"

diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml
index 3c8aaed0b6..089102a599 100644
--- a/doc/src/sgml/backup.sgml
+++ b/doc/src/sgml/backup.sgml
@@ -1520,11 +1520,11 @@ tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/
       If archive storage size is a concern, you can use
       <application>gzip</application> to compress the archive files:
 <programlisting>
-archive_command = 'gzip &lt; %p &gt; /var/lib/pgsql/archive/%f'
+archive_command = 'gzip &lt; %p &gt; /var/lib/pgsql/archive/%f.gz'
 </programlisting>
       You will then need to use <application>gunzip</application> during recovery:
 <programlisting>
-restore_command = 'gunzip &lt; /mnt/server/archivedir/%f &gt; %p'
+restore_command = 'gunzip &lt; /mnt/server/archivedir/%f.gz &gt; %p'
 </programlisting>
      </para>
     </sect3>

--1D1QAIRzwqh4K/03--

--2+gg6hdGLuxvwKOS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmA16NoACgkQnvQgOdby
QH3QRQ//UrO/WMfRsSYhG5hpPzaslsS9sUNji1Ro7UZpaQrJpCBvqV5jWiEik+tn
OGejchjomy5jmOtnC936CMtr9oqlpLpOMVsJdsb+IKcZ8D55NQ1HRI0NOktTxVSU
VltBKEik5MeSPfqaH9aXpw0gwxSDaa43m2dDpB9IU4S87jXSCKbh41Vykb12ZX2g
BL//G4ID6b5HfNSJGGdotMUXaoBVNz/ujNucOXi7IqBGts9u+1ZvSBq77+KBGXnt
dAX82D0c/jCGWzg4pHTfDBZOjg4+Khpic0/EXmIMga36frlB6mlh+Kvwk66bJsxF
3jT5PYv2xgvxRgflN4FV566XWLTIKRa62DCDXENSFEI0YO6vNOkNktVspcmuIw53
LTg7r2DbaCasezxMISy94ZTygfCn+gX2WcT3cEW6i8MuDIWfki3K4hYzWNs8Ug9T
sRcKb3/X9t0PSdGqNUbl+RbhfUnjvnVPrXeP/spiqlEaBaflu1sUVO6NALyDmAnE
s7/E1SgnUcQZrXbz3q9bOr2jRheGkgrmMsV/huDmKh3U3TP1L6TcqsC2IztO25IM
cFnjlSMIluw5dHeQBNBCaRdCfbCxS/Tl7ei9RY1IrYUufZPwbErJMchm3RB/fDWq
Eh6AHytAFgbGc0CW1L7/zfPcQDXuxfVInTWhUsS+uSVKP7fqz4A=
=RJxK
-----END PGP SIGNATURE-----

--2+gg6hdGLuxvwKOS--