Date: Thu, 25 Feb 2021 15:54:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Philipp Gramzow <phil@philphonic.de>, pgsql-docs@lists.postgresql.org
Subject: Re: incoorect restore_command
Message-ID: <YDdJvgQIiBcF6JgR@paquier.xyz>
References: <161397938841.15451.13129264141285167267@wrigleys.postgresql.org>
 <YDXo2tIJmkW6mhkm@paquier.xyz>
 <478b5b00-5ab3-a1b5-65f4-19b4409c720b@philphonic.de>
 <YDYFuW+6Y72vRk9Q@paquier.xyz>
 <3c8a08bb-3eaa-cdc6-08f9-3298342722c2@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="OYUBM7EXLPvnYYDe"
Content-Disposition: inline
In-Reply-To: <3c8a08bb-3eaa-cdc6-08f9-3298342722c2@oss.nttdata.com>
Precedence: bulk


--OYUBM7EXLPvnYYDe
Content-Type: multipart/mixed; boundary="OH8fGQ54ytqtZZJY"
Content-Disposition: inline


--OH8fGQ54ytqtZZJY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 24, 2021 at 08:15:59PM +0900, Fujii Masao wrote:
> But I have one question; why do those commands use different
> archive directories? Isn't it better to use the same one?

storage.sgml uses /var/lib/pgsql/data for the location of the data,
and the archive path is a mix between /mnt/server/archivedir/ and
/var/lib/pgsql/archive/.  However, the former is used for
pg_archivecleanup and in postgresql.conf.sample, so why not just using
/mnt/server/archivedir/ in backup.sgml?  Please see the attached.
--
Michael

--OH8fGQ54ytqtZZJY
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="doc-archive-gz-v2.patch"

diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml
index 3c8aaed0b6..d8a60f7529 100644
--- a/doc/src/sgml/backup.sgml
+++ b/doc/src/sgml/backup.sgml
@@ -1484,7 +1484,7 @@ restore_command = 'cp /mnt/server/archivedir/%f %p'
       <literal>on</literal>, and set up an <varname>archive_command</varname> that performs
       archiving only when a <emphasis>switch file</emphasis> exists.  For example:
 <programlisting>
-archive_command = 'test ! -f /var/lib/pgsql/backup_in_progress || (test ! -f /var/lib/pgsql/archive/%f &amp;&amp; cp %p /var/lib/pgsql/archive/%f)'
+archive_command = 'test ! -f /var/lib/pgsql/backup_in_progress || (test ! -f /mnt/server/archivedir/%f &amp;&amp; cp %p /mnt/server/archivedir/%f)'
 </programlisting>
       This command will perform archiving when
       <filename>/var/lib/pgsql/backup_in_progress</filename> exists, and otherwise
@@ -1501,7 +1501,7 @@ psql -c "select pg_start_backup('hot_backup');"
 tar -cf /var/lib/pgsql/backup.tar /var/lib/pgsql/data/
 psql -c "select pg_stop_backup();"
 rm /var/lib/pgsql/backup_in_progress
-tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/
+tar -rf /var/lib/pgsql/backup.tar /mnt/server/archivedir/
 </programlisting>
       The switch file <filename>/var/lib/pgsql/backup_in_progress</filename> is
       created first, enabling archiving of completed WAL files to occur.
@@ -1520,11 +1520,11 @@ tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/
       If archive storage size is a concern, you can use
       <application>gzip</application> to compress the archive files:
 <programlisting>
-archive_command = 'gzip &lt; %p &gt; /var/lib/pgsql/archive/%f'
+archive_command = 'gzip &lt; %p &gt; /mnt/server/archivedir/%f.gz'
 </programlisting>
       You will then need to use <application>gunzip</application> during recovery:
 <programlisting>
-restore_command = 'gunzip &lt; /mnt/server/archivedir/%f &gt; %p'
+restore_command = 'gunzip &lt; /mnt/server/archivedir/%f.gz &gt; %p'
 </programlisting>
      </para>
     </sect3>

--OH8fGQ54ytqtZZJY--

--OYUBM7EXLPvnYYDe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmA3Sb4ACgkQnvQgOdby
QH1bUA//fCy4TbZq0Ilt4JGEcN3xUDsXCYSWyRmOASCygnmuLV0TpJaLxnjsnJri
J1XD5pnhrQzJVx1Y9vY8dA97KAR67ajpxuxqMdNqUHcsA+13g1TH6xBk718KDY6V
TqkNaPlsa363VVZLwr+yZgsUjxPcVUBYFZvOXd4FYE5qcRe5W3YRDOXvj1FOHPac
mjMwCyqfFnTX3MTiJg722FLwVJr4nFu77KBY2IjqNdLNi2gqu1U7NlsFaqVnVdx6
pbu0XkKd/GlqhMlqVdybxpn8803mpGpsuAQshMWLFX39DTp/mGwTejUbW/LX+r28
wXoY5T8u2nvlRMZPYE5JsHwQZyKoK4BHr/xLPre3hJaR+mmQ8LaKkC7qHmnV7om4
ea/U0U26AzYoNUNv8nneRCjK8NShJQBbxzFK2Q9B4dIUNxxyROqmX7AO4MNmV99K
RiVDdmsh3YHzdvAh6HLJzfoMPhIWur5vq/lSKTsEN2nO7Alr1zE9vbDBqYmCiJ70
2ghEKylUCTASe6HOxLF/6+Htz0INqGRSKGXPf+CVq98AFeZdqszESHkOr3UDFDpY
KOUOHkqxrlWnNYcAepE/+WhvzNx/78vYH0ljfXImVt6yl9j5FKnfST3d5i1CSeuf
YBYLe9mUKeaSaA/x7RgSu8rsK2icQuy41JjDOvWcGTrzN0Kqpgc=
=dXci
-----END PGP SIGNATURE-----

--OYUBM7EXLPvnYYDe--