Date: Fri, 26 Feb 2021 14:42:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Philipp Gramzow <phil@philphonic.de>, pgsql-docs@lists.postgresql.org
Subject: Re: incoorect restore_command
Message-ID: <YDiKK883GvoSKj2z@paquier.xyz>
References: <161397938841.15451.13129264141285167267@wrigleys.postgresql.org>
 <YDXo2tIJmkW6mhkm@paquier.xyz>
 <478b5b00-5ab3-a1b5-65f4-19b4409c720b@philphonic.de>
 <YDYFuW+6Y72vRk9Q@paquier.xyz>
 <3c8a08bb-3eaa-cdc6-08f9-3298342722c2@oss.nttdata.com>
 <YDdJvgQIiBcF6JgR@paquier.xyz>
 <06d9fc43-7ea9-20cc-191e-401136bc86fa@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="exazu19mLwS+gDdj"
Content-Disposition: inline
In-Reply-To: <06d9fc43-7ea9-20cc-191e-401136bc86fa@oss.nttdata.com>
Precedence: bulk


--exazu19mLwS+gDdj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 25, 2021 at 06:03:57PM +0900, Fujii Masao wrote:
> Regarding the section "Standalone Hot Backups", all the directories and
> file seem to be placed under /var/lib/pgsql, so at least for me it looks =
a bit
> strange to change only the path of archive directory. So I don't think th=
at
> we need to do this change.
>
> -tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/
> +tar -rf /var/lib/pgsql/backup.tar /mnt/server/archivedir/
>=20
> Same as above.

Okay.  I found the thing a bit inconsistent while looking at the whole
picture.  Anyway, dropped those two parts.

> -archive_command =3D 'gzip &lt; %p &gt; /var/lib/pgsql/archive/%f'
> +archive_command =3D 'gzip &lt; %p &gt; /mnt/server/archivedir/%f.gz'
>  </programlisting>
>        You will then need to use <application>gunzip</application> during=
 recovery:
>  <programlisting>
> -restore_command =3D 'gunzip &lt; /mnt/server/archivedir/%f &gt; %p'
> +restore_command =3D 'gunzip &lt; /mnt/server/archivedir/%f.gz &gt; %p'
>=20
> LGTM. Thanks for the patch!

Thanks for the review.  I have applied only this part, then.
--
Michael

--exazu19mLwS+gDdj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmA4iisACgkQnvQgOdby
QH1laA/7B8C0iL2SFSlugj1lDjjKKMGkczxIHMmGrQgX3JLjkxsOqCmQzNQ5i/sr
sST1ALWaKUyHFaxoSuF9Lan1ZhB8kkt/XXDkoqKEnoZbPKjHVYkgOQgXzmL9r1jo
BbixpFmENPRSp8wrU3QVDvU1II4g6AI+5vUypktF3m6ddrWDBOSVERNpyTe9z20Z
Q0hpd5dLXYjAu1pwRx72k/zWPP6Cw33TRdP1c20afmeeWif28eZrmKmJjCjVzQFq
xJObmmZE+5Lll+mSRr/kQb451DTeOKW5lkhHg0rDQ+2L86gDBVaFeFlqBoNLSpah
tt1BCpmgsAQIVsaji7izzyip/JguJO02GauqU89vuku1PHalc7SwCYjNLOThbspX
+tWPyWgD8GX0ACwYX55s87buPNxGjAPnXrVLehq+/sUYDAhIz29Mz1CaCMLbHYi4
8uwtxtRl9xlSex2MSzSBrOMdvLajAs4IEoOpvIPSY+bRHahtBjtw+rspTn3IOfwz
Qk6usKgZLgSTY9ljBwz111onxXw3hYohsq2l6xRB0AZz8CTSntIkOAtjXtb2HVsu
fHnjwgWMibKiIbI6QjsUp/G0xa5wSMMYJN3TKEqpxWDEBJXpRZRCAz8ewStlVGfr
jCi8nKIBU43hjBM5oNQBzI069SnwWIyNZgvAicq8mqji/Au1kDU=
=V1Sk
-----END PGP SIGNATURE-----

--exazu19mLwS+gDdj--