Date: Wed, 9 Mar 2022 15:04:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: leslie.lemaire@developpement-durable.gouv.fr,
	pgsql-docs@lists.postgresql.org
Subject: Re: Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger
 Firing Matrix
Message-ID: <YihDVYONoLuU5oqY@paquier.xyz>
References: <164647533363.646.5802968483136493025@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wSGVnFJR2HWTa3ai"
Content-Disposition: inline
In-Reply-To: <164647533363.646.5802968483136493025@wrigleys.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/YihDVYONoLuU5oqY%40paquier.xyz>
Precedence: bulk


--wSGVnFJR2HWTa3ai
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Leslie,

On Sat, Mar 05, 2022 at 10:15:33AM +0000, PG Doc comments form wrote:
> "ALTER ROUTINE" and "DROP ROUTINE" are not listed in the "Event Trigger
> Firing Matrix" documentation page, even though these tags seem supported
> from PostgreSQL 11 onwards.
>=20
> It would be really useful to mention them, since alterations and deletions
> of functions and procedures through ALTER ROUTINE and DROP ROUTINE comman=
ds
> won't be caught by a trigger firing only on "ALTER PROCEDURE" and "ALTER
> FUNCTION" tags (respectively "DROP PROCEDURE" and "DROP FUNCTION" tags).

Thanks for the report.  Indeed, the table is missing that ALTER
ROUTINE would fire the events ddl_command_start and ddl_command_end.
DROP ROUTINE fires on sql_drop, ddl_command_start and
ddl_command_end.  I have applied a patch to add this information
to the docs down to 11.

Regards,
--
Michael

--wSGVnFJR2HWTa3ai
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIoQ1UACgkQnvQgOdby
QH3N4Q//WgtzLYQnIZwUgsy1KOFzvCPFyU1Ga75A9j5813h1SltAGFMsDklDxADr
V8JfJ9Co2Kl3Gq6yChzbhukPgtDkdIJX9hxw8FKNvqrKXivWBUD5d02q3a6Btv6K
svv+jNJT9HNM53V9TRV06naiRPozseMG+iYv/eOVEvpf7mro314DCtTYUubhneBt
cdpsAockV5gwJxFrR6F+fXHbI184ZnY/JI2mj4KkI14Mi8YuIe/QCTEz9YuBhWrk
kY9ak7OlFcLNq8JY6Q6t+VcWjmePhDOFgNw/Stwk1LNga4yJQVSqbz5AQH49NwW2
rS2lQP2v8gxsAXGyp25mIvYqPmRewbnqItjeP/s10VPw4349rNw1NcZ9uJAJi2ub
+Qt1jD+uGS5Au3EBAee+c+h5ZmNYXKVqai84JiTFDoJVmdFARnYCqmNbbxma+8AQ
sREPCxEwqB14ppnR4gyygtLhW+DH3x83wiAB9IN6dMnzl5IPx8vaRIUsi+kNADF+
ObSnNd69xfOeQsXwAENMBsfvkIAMpyf7gZTwCJEMNgbsMxPUPse+Beb3neUUwB8T
jCIT3fMxZ3HGSfSZk79nUKm/3KNZRKjbVYJ6EdjfUMb97OkUUEwWWqfQn/NUl2NU
q5VZAjx8ewVsp/ikzfgW7xgt6uLtIWw7l6SXdlM7mDfCzWa8KnY=
=klBe
-----END PGP SIGNATURE-----

--wSGVnFJR2HWTa3ai--