public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: Nikhil Shetty <[email protected]>
Cc: Jack DeVries <[email protected]>
Cc: [email protected]
Subject: Re: Fwd: Adding more detail to pg_upgrade documentation
Date: Sat, 9 Jul 2022 22:38:30 -0400
Message-ID: <Yso7pu6UIJFvx/[email protected]> (raw)
In-Reply-To: <CAFpL5VxzjWnfBR0yPUmt+GBsVWRfi_m5dk4M-694dcGn7EqcrQ@mail.gmail.com>
References: <CAFpL5Vx7Z676aa+Gyg6igONDDg+Pmoy=vyZ1Vc0YiZKc-Cyp1A@mail.gmail.com>
<CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68NOX8+PUA@mail.gmail.com>
<[email protected]>
<CAFpL5VxzjWnfBR0yPUmt+GBsVWRfi_m5dk4M-694dcGn7EqcrQ@mail.gmail.com>
On Sat, Jun 4, 2022 at 03:08:58PM +0530, Nikhil Shetty wrote:
> Hi Jack,
>
> I followed the same steps multiple times but each time, slot had to be
> recreated.
>
> The slots under directory pg_replslot are not created in the new cluster during
> pg_upgrade.
>
> Thanks and Regards,
> Nikhil
>
> On Sat, 4 Jun 2022 at 1:48 AM, Jack DeVries <[email protected]> wrote:
>
> Hi Nikhil,
>
> >From the pgupgrade docs:
>
> > 9. Prepare for standby server upgrades
> >
> > If you are upgrading standby servers using methods outlined in section
> > Step 11, verify that the old standby servers are caught up by running
> > pg_controldata against the old primary and standby clusters. Verify
> > that the “Latest checkpoint location” values match in all clusters.
> > (There will be a mismatch if old standby servers were shut down before
> > the old primary or if the old standby servers are still running.)
> > Also, make sure wal_level is not set to minimal in the postgresql.conf
> > file on the new primary cluster.
>
> (source: https://www.postgresql.org/docs/devel/pgupgrade.html)
>
> I'm a new contributor so please forgive me if I'm on the wrong track,
> but if you follow this step, won't you also be ensuring that replication
> slots do not need to be migrated, since you've just ensured that standby
> clusters are in sync with the primary cluster? Please let me know if I'm
> missing anything!
I have written the attached patch to document this.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson
Attachments:
[text/x-diff] slots.diff (680B, 2-slots.diff)
download | inline diff:
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index f3eb7fbd33..d065227656 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -619,7 +619,8 @@ rsync --archive --delete --hard-links --size-only --no-inc-recursive /vol1/pg_tb
Configure the servers for log shipping. (You do not need to run
<function>pg_backup_start()</function> and <function>pg_backup_stop()</function>
or take a file system backup as the standbys are still synchronized
- with the primary.)
+ with the primary.) Replication slots are not copied and must
+ be recreated.
</para>
</step>
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fwd: Adding more detail to pg_upgrade documentation
In-Reply-To: <Yso7pu6UIJFvx/[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox