Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1oEti2-0004Jy-Kg
	for pgsql-docs@arkaria.postgresql.org; Fri, 22 Jul 2022 14:32:54 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1oEthz-0006cp-SI
	for pgsql-docs@arkaria.postgresql.org; Fri, 22 Jul 2022 14:32:51 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1oEthz-0006cg-Kj
	for pgsql-docs@lists.postgresql.org; Fri, 22 Jul 2022 14:32:51 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1oEthv-0001kq-NH
	for pgsql-docs@lists.postgresql.org; Fri, 22 Jul 2022 14:32:51 +0000
Received: from bruce by momjian.us with local (Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1oEthq-008lYB-EX; Fri, 22 Jul 2022 10:32:42 -0400
Date: Fri, 22 Jul 2022 10:32:42 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Liam Bowen <liambowen@gmail.com>, pgsql-docs@lists.postgresql.org
Subject: Re: gettext instructions for Windows seems wrong
Message-ID: <Ytq1CmkfqXQ35ljC@momjian.us>
References: <164246013804.31952.4958087335645367498@wrigleys.postgresql.org>
 <AE6ADA74-7F1A-48BE-8307-3C48574A0439@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="sKB2ClHDatZHrlhF"
Content-Disposition: inline
In-Reply-To: <AE6ADA74-7F1A-48BE-8307-3C48574A0439@yesql.se>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/Ytq1CmkfqXQ35ljC%40momjian.us>
Precedence: bulk


--sKB2ClHDatZHrlhF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 19, 2022 at 10:24:57AM +0100, Daniel Gustafsson wrote:
> > On 17 Jan 2022, at 23:55, PG Doc comments form <noreply@postgresql.org> wrote:
> 
> > The instructions say that I have to edit config.pl (actually, I had to
> > create it)..
> 
> I know next to nothing about NLS on Windows, but regardless of doc updates for
> this I think we should clarify that config.pl may not exist, like how we do for
> buildenv.pl.

Good point --- I have developed the attached patch to implement this.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson


--sKB2ClHDatZHrlhF
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="nls.diff"

diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml
index afb004b5cf..11e153578c 100644
--- a/doc/src/sgml/install-windows.sgml
+++ b/doc/src/sgml/install-windows.sgml
@@ -122,7 +122,7 @@
  </para>
 
  <para>
-  Before you build, you may need to edit the file <filename>config.pl</filename>
+  Before you build, you can create the file <filename>config.pl</filename>
   to reflect any configuration options you want to change, or the paths to
   any third party libraries to use. The complete configuration is determined
   by first reading and parsing the file <filename>config_default.pl</filename>,

--sKB2ClHDatZHrlhF--