public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: David G. Johnston <[email protected]>
Cc: [email protected]
Cc: Pg Docs <[email protected]>
Subject: Re: CREATE TABLE AS, section IF NOT EXISTS should clarify what happens to the data
Date: Fri, 12 Aug 2022 10:58:37 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CAKFQuwY30ro-xosyLZc=qFO3UhnudwvHO4oOJDqGawdQrtUWSA@mail.gmail.com>
	<[email protected]>

On Mon, Jul 18, 2022 at 03:43:03PM -0400, Bruce Momjian wrote:
> fOn Thu, Jul 14, 2022 at 06:47:19PM -0700, David G. Johnston wrote:
> > Not only is the existing table not modified, I think that the select query
> > portion of the command is never even executed.  That would seem to be useful
> > knowledge to have.
> > 
> > Maybe something like:
> > 
> > <para>
> >  Do not throw an error if a relation with the same name already exists.
> >  A notice is issued in this case.
> >  If <literal>WITH DATA</literal> is specified (the default) the execution of
> > the parsed query does not happen, leaving the existing table with its existing
> > contents.
> > </para>
> 
> I tried to go in that direction, but couldn't clearly name the
> SELECT/VALUES part of the CREATE TABLE AS query because CREATE TABLE
> AS is also a query.  I felt trying to say we ran the CREATE TABLE AS
> query but not the SELECT/VALUES of the query was just too confusing.  I
> used "simply issue a notice" as implying that nothing else happens,
> which I considered sufficient.
> > 
> > I've removed the xref to create table as there is nothing additional there of
> > material benefit - the sentence:
> 
> Okay, removed.  Updated patch attached.

Patch applied back to PG 10.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: CREATE TABLE AS, section IF NOT EXISTS should clarify what happens to the data
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox