Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 25 Nov 2024 09:06:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Erik Wienhold <ewie@ewie.name>
Cc: el481@yandex.ru, pgsql-docs@lists.postgresql.org
Subject: Re: Misprints in code
Message-ID: <Z0O_fd8tXxw12klx@paquier.xyz>
References: 
 <173209043143.2092749.13692266486972491694@wrigleys.postgresql.org>
 <fe60c0fa-cea7-4c6e-b951-28f566289550@ewie.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZS5GL12+0nzivjnN"
Content-Disposition: inline
In-Reply-To: <fe60c0fa-cea7-4c6e-b951-28f566289550@ewie.name>
Archived-At: 
 <https://www.postgresql.org/message-id/Z0O_fd8tXxw12klx%40paquier.xyz>
Precedence: bulk


--ZS5GL12+0nzivjnN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 21, 2024 at 04:31:07PM +0100, Erik Wienhold wrote:
> Good catch!  That's a leftover from Python 2 and missed in commit
> 4228cabb72b after Python 2 was dropped in 15.0.  Patch attached.
>=20
> While looking at, we can also simplify a couple of plpython3u test
> functions that still try res.next() before res.__next__().  Attached as
> a separate patch.

Sounds about right to me, the example greet() fails with plpython3.
For reference, this has been implemented in upstream here:
https://peps.python.org/pep-3114/

The existing tests of plpython mentioned this link, and I've bumped
over it again while looking for references on the matter.

Will fix.  Thanks for the report!
--
Michael

--ZS5GL12+0nzivjnN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdDv30ACgkQnvQgOdby
QH1I1RAAmTXPzzACs4JsMRufVJ21eCujoQ66g9GSD/FhosKJN40pnL11Wwu7vl/X
aC70Ggadp68oJZ3vGlo2hDkmQETFYuxBg7IG9sk+k2yqtsscUqTNqxLuF05wP5k9
FMkyx5m41eFG5dnjfgT1eJQz++B0LWZbQ0i9vnwmsdAjEL7suSYaU27bGiBvrtn2
7jVi1B/8yqDbpzXBw9xggNIcpknPi0qIspUsFltBTC7w1MfOHj4DLwTRnk7b35eV
eXqbtJxlbRqcm22RS62VR4n7FIDrGjjgbAiKywykHBTZfSsYuK87svLauNRSQvJb
kq22WpjKgDiLoitdkVoRwac8aviRJL9WAZtiBIwMq1AqOqhKCmnQP/EorFiUaTaI
bwnmXbnN33uNDE8T76eIjky1YdiradaM60cRSPwYCeX5JQO/Npybzs4tv1yDPNkJ
aQhSQZH4A4O59kmgZAfgsRIOk9j89oESKP9WgRjr59cvnwkywVZhouwG2BWXE6X6
C8PeUQkfxb6+zR079eHtC7o1XOemDAZ7ZBVZmbql2NmxAQVO3G16bV2RhoaUd8o+
c045kePeFtYA6Q3NESx/v6JsXc8AIGrzuE6b2dClLrjfOT84Eadc7aqgGs+AqPzc
7nddWkiE+s1X9FMXZz/hvR9YwocZy0ooDC/SLyskgvbpIXRzhWE=
=CanC
-----END PGP SIGNATURE-----

--ZS5GL12+0nzivjnN--