Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1tlRhu-00C4W6-5c
	for pgsql-docs@arkaria.postgresql.org; Fri, 21 Feb 2025 12:00:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1tlRhs-008U35-8X
	for pgsql-docs@arkaria.postgresql.org; Fri, 21 Feb 2025 12:00:36 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1tlRhs-008U2x-1E
	for pgsql-docs@lists.postgresql.org; Fri, 21 Feb 2025 12:00:36 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1tlRhq-0025TD-1G
	for pgsql-docs@lists.postgresql.org;
	Fri, 21 Feb 2025 12:00:35 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us;
	s=2025010100; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
	Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
	Content-Description; bh=nkd/UVrZuzJbbTRGGBj/3eX4d1/5Y6ePvyyM3SDuL6o=; b=gVsmS
	JtoPtACwp3hUWGwXSD+N7bvlyqkjEUt05smjqnWSgQ5KCMEhuyJFCm+NPyMvPgThhhO2Qbo5td433
	EdFhUybS0zW6Rc8IZ7p1QCAW3HPunHVt/QjMum49eguOzY7wPNHQbVCZcWvSzOrA6v1kDBk80tZQ5
	gDbD6+tRtSU5cHMu3LDHpDqPmmRZnmuaEeDmAFYVr2EaSqFpWgps5zt6T6ehgAdSPArVSWEHcoVXx
	EzR8ofYiRAnmZVYtZ2XKcePKyZZptbG4w/gA/ugW61cvVtvmahs7JBjMX/itt0pN3gnTYuJlaoRNu
	/74G0sZrBci9r+AQP1134mg1S0/Ig==;
Received: from bruce by momjian.us with local (Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1tlRho-005olj-1I;
	Fri, 21 Feb 2025 07:00:32 -0500
Date: Fri, 21 Feb 2025 07:00:32 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: afripowered@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Second paragraph a little bit misleading
Message-ID: <Z7hq4D_QMwR85DOO@momjian.us>
References: <173928241056.707.3989867022954178032@wrigleys.postgresql.org>
 <Z7dak8fwxwezBhyh@momjian.us>
 <43db6e44e5bc8c6f22eb439c8256f1e1bc135cf7.camel@cybertec.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43db6e44e5bc8c6f22eb439c8256f1e1bc135cf7.camel@cybertec.at>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/Z7hq4D_QMwR85DOO%40momjian.us>
Precedence: bulk

On Fri, Feb 21, 2025 at 08:25:56AM +0100, Laurenz Albe wrote:
> On Thu, 2025-02-20 at 11:38 -0500, Bruce Momjian wrote:
> > On Tue, Feb 11, 2025 at 02:00:10PM +0000, PG Doc comments form wrote:
> > > Page: https://www.postgresql.org/docs/17/checksums.html
> > > 
> > > I think that the first sentence of the second paragraph in this page is a
> > > little bit misleading. The first paragraph states that checksums are not
> > > enabled by default. The first sentence in the second paragraph sounds like
> > > it IS enabled by default when using initdb, but you have to pass -k
> > > explicitly.
> > 
> > I can see your point.  Attached is a doc patch that improves it.  I
> > chose very simple language and plan to backpatch this to all supported
> > versions.
> >
> > diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
> > index 52b5b8f793b..705ca682777 100644
> > --- a/doc/src/sgml/wal.sgml
> > +++ b/doc/src/sgml/wal.sgml
> > @@ -246,7 +246,7 @@
> >    </para>
> >  
> >    <para>
> > -   Checksums are normally enabled when the cluster is initialized using <link
> > +   Checksums can be enabled when the cluster is initialized using <link
> >     linkend="app-initdb-data-checksums"><application>initdb</application></link>.
> >     They can also be enabled or disabled at a later time as an offline
> >     operation. Data checksums are enabled or disabled at the full cluster
> 
> The change looks good for the back branches, but the default has changed
> in v18: now checksums are the default.  So "can be enabled" doesn't sound
> right for v18.  I'd leave "are normally enabled" in HEAD.

Yes, I was confused about that too, but I think we changed the code for
the development branch and if we decide to keep the new default, we will
change the docs later.  I didn't want to interfere with that.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.