Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1qlAF0-001Y9X-W4
	for pgsql-docs@arkaria.postgresql.org; Tue, 26 Sep 2023 15:44:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1qlAEz-00D1Bh-2y
	for pgsql-docs@arkaria.postgresql.org; Tue, 26 Sep 2023 15:44:49 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1qlAEy-00D1BV-QL
	for pgsql-docs@lists.postgresql.org; Tue, 26 Sep 2023 15:44:48 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1qlAEv-007hzb-Oj
	for pgsql-docs@lists.postgresql.org; Tue, 26 Sep 2023 15:44:48 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us;
	s=2023062407; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
	Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:
	Content-Description; bh=HxRH4W3CrlQuQJniTAZY/qgN4ZHsk+iQfolASgQZcVE=; b=ttHf3
	LoZLJMDIDHIGKDvN8gwNmRRwxTwQF/C7iRnlweJkoBAWW1XJNGFJBfmgEEoxRAa5nC3mz3TK13LQV
	paZHrO0bd9nWHT3VDqhaPvoVQuxw7f4XwP/Vvqdt1VaoqnA/J7jubpUICpFsnh8Kzom4F26UOvcKL
	yuWbwfX2grhocraM6ulh4py2bZxoCx2e8lbXGpq7/HDIZyQpWzmqclMs5qG7Z++R03sSlqREKyKSc
	zrDySJett4q6RzoIa1Aq3OjtxnpMEdlwNqVEDqU/JnIDfswYWywq0E9BgAbWJfCvczE0JvjoXy3R5
	L6rYHW2kGOYTHOO7N3lYOzLVPzD2Q==;
Received: from bruce by momjian.us with local (Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1qlAEs-00FRvO-31;
	Tue, 26 Sep 2023 11:44:42 -0400
Date: Tue, 26 Sep 2023 11:44:42 -0400
From: Bruce Momjian <bruce@momjian.us>
To: mortoozseydi@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: correct documentation in set role
Message-ID: <ZRL8alby8rOrm3Tu@momjian.us>
References: <169562797830.3727336.2047897773232975635@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="eTuyN0wry+w6IUYx"
Content-Disposition: inline
In-Reply-To: 
 <169562797830.3727336.2047897773232975635@wrigleys.postgresql.org>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/ZRL8alby8rOrm3Tu%40momjian.us>
Precedence: bulk


--eTuyN0wry+w6IUYx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 25, 2023 at 07:46:18AM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/16/sql-set-role.html
> Description:
> 
> it is good to mention that: 
> The specified role_name must be a role that the current session user is a
> member of "and has SET True option on it."
> The second part missed in documentation for set role command.

Good point.  How is the attached patch?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.

--eTuyN0wry+w6IUYx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="set_role.diff"

diff --git a/doc/src/sgml/ref/set_role.sgml b/doc/src/sgml/ref/set_role.sgml
index 13bad1bf66..a2661945aa 100644
--- a/doc/src/sgml/ref/set_role.sgml
+++ b/doc/src/sgml/ref/set_role.sgml
@@ -42,7 +42,8 @@ RESET ROLE
 
   <para>
    The specified <replaceable class="parameter">role_name</replaceable>
-   must be a role that the current session user is a member of.
+   must be a role that the current session user is a member of and
+   is granted <literal>WITH SET TRUE</literal>.
    (If the session user is a superuser, any role can be selected.)
   </para>
 

--eTuyN0wry+w6IUYx--