Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1qlERp-001qlg-L0
	for pgsql-docs@arkaria.postgresql.org; Tue, 26 Sep 2023 20:14:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1qlERn-00EkNB-To
	for pgsql-docs@arkaria.postgresql.org; Tue, 26 Sep 2023 20:14:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1qlERn-00EkMw-Kk
	for pgsql-docs@lists.postgresql.org; Tue, 26 Sep 2023 20:14:19 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1qlERj-007kYe-NZ
	for pgsql-docs@lists.postgresql.org; Tue, 26 Sep 2023 20:14:18 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us;
	s=2023062407; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
	Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:
	Content-Description; bh=UAAwRp37nQUOKqSzZSrDZ/fNPWD5ZdzCClAGUBS9dRQ=; b=iUQ0L
	Y9AvL7XFpzw4xLHeIdy302YkdKxKZJeb7ika6SIYcxJfZoCcn+WwKjJhO+jimQZ7ztbz0G9BThxDQ
	uNsE7959tAPJa6xFLaoE4kp1FdAzZxbrW3Wbb//iOeUl/ekFGpjOl6Y/D1RLp8LISJu6tu06TMnAg
	XfxwxqbRoz+cgFcwCaJGY37DolPVt1nfwRfP0uockACfWAyJ+UwKeQb6BbSB8pOJM+X6CSEeHufVG
	ioY0ifqPs9IaKlsD7IuJUT+2qaKakqgM2T3+vPfpdiKYU/IO3/y+siXsCPFn4d2v4KmcoxnVDfT2h
	a+KhG06g9LeoNdCEInEQ201iQ7dhw==;
Received: from bruce by momjian.us with local (Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1qlERi-00Geho-0c;
	Tue, 26 Sep 2023 16:14:14 -0400
Date: Tue, 26 Sep 2023 16:14:14 -0400
From: Bruce Momjian <bruce@momjian.us>
To: mortoozseydi@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: correct documentation in set role
Message-ID: <ZRM7ligKnAf6svID@momjian.us>
References: <169562797830.3727336.2047897773232975635@wrigleys.postgresql.org>
 <ZRL8alby8rOrm3Tu@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZRL8alby8rOrm3Tu@momjian.us>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/ZRM7ligKnAf6svID%40momjian.us>
Precedence: bulk

On Tue, Sep 26, 2023 at 11:44:42AM -0400, Bruce Momjian wrote:
> On Mon, Sep 25, 2023 at 07:46:18AM +0000, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> > 
> > Page: https://www.postgresql.org/docs/16/sql-set-role.html
> > Description:
> > 
> > it is good to mention that: 
> > The specified role_name must be a role that the current session user is a
> > member of "and has SET True option on it."
> > The second part missed in documentation for set role command.
> 
> Good point.  How is the attached patch?

> diff --git a/doc/src/sgml/ref/set_role.sgml b/doc/src/sgml/ref/set_role.sgml
> index 13bad1bf66..a2661945aa 100644
> --- a/doc/src/sgml/ref/set_role.sgml
> +++ b/doc/src/sgml/ref/set_role.sgml
> @@ -42,7 +42,8 @@ RESET ROLE
>  
>    <para>
>     The specified <replaceable class="parameter">role_name</replaceable>
> -   must be a role that the current session user is a member of.
> +   must be a role that the current session user is a member of and
> +   is granted <literal>WITH SET TRUE</literal>.
>     (If the session user is a superuser, any role can be selected.)
>    </para>

Someone is already working on this text addition from a post yesterday:

	https://www.postgresql.org/message-id/20230925220945.GB3172533%40nathanxps13

Please ignore my patch and I will be sure the patch at this URL gets
committed.  Thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.