Date: Thu, 9 Nov 2023 17:02:53 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: greatvovan@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: User mapping security
Message-ID: <ZU1XDU7dWU1zLLv2@tamriel.snowman.net>
References: <156324246053.1191.5972769566826595079@wrigleys.postgresql.org>
 <ZU1SOvgnwbBawgzN@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="srpxXEp55q8JK2D/"
Content-Disposition: inline
In-Reply-To: <ZU1SOvgnwbBawgzN@momjian.us>
User-Agent: Mutt/2.1.4 (2021-12-11)
Archived-At: 
 <https://www.postgresql.org/message-id/ZU1XDU7dWU1zLLv2%40tamriel.snowman.net>
Precedence: bulk


--srpxXEp55q8JK2D/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Bruce Momjian (bruce@momjian.us) wrote:
> On Tue, Jul 16, 2019 at 02:01:00AM +0000, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> >=20
> > Page: https://www.postgresql.org/docs/10/postgres-fdw.html
> > Description:
> >=20
> > Regarding the documentation pages
> > https://www.postgresql.org/docs/10/postgres-fdw.html?origin_team=3DT02H=
EPYKQ
> > and https://www.postgresql.org/docs/10/sql-createusermapping.html
> >=20
> > I suppose it should be warned on the pages that foreign credentials wit=
h be
> > stored as simple text and will be available for viewing in pg_user_mapp=
ings.
>=20
> I know this is four years old, but the attached patch documents it.  I
> don't think postgresql-fdw needs it since it relies on user mapping and
> discourages passwords in the connection string.

A bit on the fence about it ... but I do wonder if we should encourage
use of gssapi and credential delegation now that we support that and
point out that storing passwords isn't required if you're using gssapi.

Thanks,

Stephen

> diff --git a/doc/src/sgml/ref/create_user_mapping.sgml b/doc/src/sgml/ref=
/create_user_mapping.sgml
> index 55debd5401..e93bfe48f6 100644
> --- a/doc/src/sgml/ref/create_user_mapping.sgml
> +++ b/doc/src/sgml/ref/create_user_mapping.sgml
> @@ -92,7 +92,11 @@ CREATE USER MAPPING [ IF NOT EXISTS ] FOR { <replaceab=
le class=3D"parameter">user_
>        This clause specifies the options of the user mapping.  The
>        options typically define the actual user name and password of
>        the mapping.  Option names must be unique.  The allowed option
> -      names and values are specific to the server's foreign-data wrapper.
> +      names and values are specific to the server's foreign-data
> +      wrapper.  Option values, including passwords, are visible in the
> +      <link
> +      linkend=3D"catalog-pg-user-mapping"><structname>pg_user_mapping</s=
tructname></link>
> +      system view.
>       </para>
>      </listitem>
>     </varlistentry>


--srpxXEp55q8JK2D/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmVNVw0ACgkQ7WyKOINH
ZFXb8g/+JhNqopvHrdcZ60Syc0RSCGklRGZ8Map4kWj8jRoUmNhc2OXFtDKnPbXJ
8D+v+Eb7MJgbYycRHkiHfqF0gCH1dcm0WLxuH3WxcWc1f6l9WrxGTgnYiMJOQnOD
NVDUelf7Vgy8PSTMNtZFuj+LvJLoDMuh4S6sSHB1zzok+gP4hr59kX34EHI+fqJh
s2WQHTGegNeo8/OgIB9s1BWjjOQ9mcOVS11Pwaw/3vTc+hOljaiKCOTvojBfGWcG
spYzLctXVE/91cqJO6r1P3BXtGAA4Y11YwjC81kbzjtL8QhGITrKlEiwST3+Zf9P
TpsD29XwrmXmnCrty5dBW+bv86SHqlUsxTTQxbY5SN5B26Eou2NPI+f3TTNtXxPc
f57l/5hAY9jm9viVSzBdyF7c+lDxqeoKngH1R6Te7MAq0fO8QChTqulQot34q7v5
Aisfy7dHcIIzkYK9E1Mbd9jNJ8wuk2VM61ySPWL6hbe6Pv62zTB9+ekfiY23tukx
vVfJt5eGOxrvcsv9FTKbl1suWNMP/qnkAtBAgp473WE5sF1971zpWts8r3oiAS0k
u3YZ8bFL31tV1A7Bb38nKh6gMTmu6WZutrJPraGJi0pescOD+76qbmCMssNemZZT
4xQSgGNlniTLYLW9yrfdxPl5BlYoqxojPmCAU72ls9SRHFDBoo8=
=oESd
-----END PGP SIGNATURE-----

--srpxXEp55q8JK2D/--