Date: Thu, 9 Nov 2023 17:52:26 -0500
From: Bruce Momjian <bruce@momjian.us>
To: evan.macbeth@crunchydata.com, pgsql-docs@lists.postgresql.org
Subject: Re: WAL Configuration Grammar Fix
Message-ID: <ZU1iqgtsMMze2ATJ@momjian.us>
References: <155208475619.1380.12815553062985622271@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="J2x5vvS0aJHmeCPW"
Content-Disposition: inline
In-Reply-To: <155208475619.1380.12815553062985622271@wrigleys.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ZU1iqgtsMMze2ATJ%40momjian.us>
Precedence: bulk


--J2x5vvS0aJHmeCPW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar  8, 2019 at 10:39:16PM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/11/wal-configuration.html
> Description:
> 
> On the WAL Configuration page -
> https://www.postgresql.org/docs/current/wal-configuration.html
> It reads: "On Linux and POSIX platforms checkpoint_flush_after allows to
> force the OS that pages written by the checkpoint should be flushed to disk
> after a configurable number of bytes."
> 
> I believe a "you" is missing. I also suggest a more clear sentence
> construction might be:
> "On Linux and POSIX platforms you can use checkpoint_flush_after to set a
> configurable number of bytes after which the OS will be forced to flush to
> disk the pages written by the checkpoint."

This patch is 4.5 years old, but still valid.  Fixed with the attached
patch applied to master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.

--J2x5vvS0aJHmeCPW
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="master.diff"

diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index 4aad0e1a07..184404c6c5 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -602,7 +602,7 @@
 
   <para>
    On Linux and POSIX platforms <xref linkend="guc-checkpoint-flush-after"/>
-   allows to force the OS that pages written by the checkpoint should be
+   allows you to force OS pages written by the checkpoint to be
    flushed to disk after a configurable number of bytes.  Otherwise, these
    pages may be kept in the OS's page cache, inducing a stall when
    <literal>fsync</literal> is issued at the end of a checkpoint.  This setting will

--J2x5vvS0aJHmeCPW--