Date: Tue, 31 Oct 2023 10:21:50 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "Jonathan S. Katz" <jkatz@postgresql.org>,
	"David G. Johnston" <david.g.johnston@gmail.com>, splarv@ya.ru,
	pgsql-docs@lists.postgresql.org
Subject: Re: 'value' has special behaviour in alter system
Message-ID: <ZUENfhZ_6MyvA_6c@momjian.us>
References: <167105927893.1897.13227723035830709578@wrigleys.postgresql.org>
 <CAKFQuwbefvj25vYz-0KJ-62oCg8-BxAd3PButBZTJ-7PzUcGbQ@mail.gmail.com>
 <f601ac59-16f9-0b75-2831-e212bae7fda5@postgresql.org>
 <3417417.1671124227@sss.pgh.pa.us>
 <ZTf50EnaCrfbyWaV@momjian.us>
 <831891.1698170753@sss.pgh.pa.us>
 <ZTgOnpx_FQx-aF5g@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZTgOnpx_FQx-aF5g@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/ZUENfhZ_6MyvA_6c%40momjian.us>
Precedence: bulk

On Tue, Oct 24, 2023 at 02:36:14PM -0400, Bruce Momjian wrote:
> On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > I have developed the attached patch to document this.
> > 
> > This seems a little imprecise:
> > 
> > +      Values with non-alphanumeric characters must be quoted.
> > 
> > I think accurate is more like "Values that are neither a number
> > nor a valid identifier must be quoted."
> > 
> > Also, that para already mentions that the input can be a
> > comma-separated list when appropriate, so your add-on para seems
> > partially repetitive.  I think you could just drop the first
> > sentence of it.
> 
> Agreed, updated patch attached.

Patch applied to all supported versions.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.