Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 1 Nov 2023 09:18:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, Euler Taveira <euler@eulerto.com>,
	eric.mutta@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Typo in "43.9.1. Reporting Errors and Messages"?
Message-ID: <ZUGZZ-J_AeeWM4_o@paquier.xyz>
References: <165931062346.271448.12881330344096283605@wrigleys.postgresql.org>
 <e222845e-8ee4-4aba-8dab-dc59827c61c6@www.fastmail.com>
 <ZUEUnLevXyW7DlCs@momjian.us>
 <8247bd59-6c9d-b56b-94f0-6e01993473cd@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cS1F8NUiZ7pO6wdi"
Content-Disposition: inline
In-Reply-To: <8247bd59-6c9d-b56b-94f0-6e01993473cd@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZUGZZ-J_AeeWM4_o%40paquier.xyz>
Precedence: bulk


--cS1F8NUiZ7pO6wdi
Content-Type: multipart/mixed; boundary="geDe2P8CTvuhyH3/"
Content-Disposition: inline


--geDe2P8CTvuhyH3/
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 31, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote:
> I don't remember details, but I think the primary reason for the change
> was that "RAISE_EXCEPTION" occurred in the whole tree only once (before
> 66bde49d96). Now I see, that I had chosen the wrong replacement =E2=80=94=
 I agree
> with Euler, change to "raise_exception" would be more appropriate.

Indeed, it looks like the origin of the confusion is the casing here,
so changing to "raise_exception" like in the appendix sounds good to
me:
https://www.postgresql.org/docs/devel/errcodes-appendix.html

So you mean something like the attached then?

> (I've found a similar mention of ERRCODE_xxx in btree.sgml:
> =C2=A0 Before doing so, the function should check the sign
> =C2=A0 of <replaceable>offset</replaceable>: if it is less than zero, rai=
se
> =C2=A0 error <literal>ERRCODE_INVALID_PRECEDING_OR_FOLLOWING_SIZE</litera=
l> (22013)
> =C2=A0 with error text like <quote>invalid preceding or following size in=
 window
> =C2=A0 function</quote>.
> but I think that's okay here, because that identifier supposed to be used
> as-is in ereport/elog.)

Yep, still this one is not that old (0a459cec96d3).
--
Michael

--geDe2P8CTvuhyH3/
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="plpg-errcode-doc.patch"

diff --git a/doc/src/sgml/plpgsql.sgml b/doc/src/sgml/plpgsql.sgml
index 83f867f91d..5977534a62 100644
--- a/doc/src/sgml/plpgsql.sgml
+++ b/doc/src/sgml/plpgsql.sgml
@@ -3942,7 +3942,7 @@ RAISE unique_violation USING MESSAGE = 'Duplicate user ID: ' || user_id;
    <para>
     If no condition name nor SQLSTATE is specified in a
     <command>RAISE EXCEPTION</command> command, the default is to use
-    <literal>ERRCODE_RAISE_EXCEPTION</literal> (<literal>P0001</literal>).
+    <literal>raise_exception</literal> (<literal>P0001</literal>).
     If no message text is specified, the default is to use the condition
     name or SQLSTATE as message text.
    </para>

--geDe2P8CTvuhyH3/--

--cS1F8NUiZ7pO6wdi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVBmWcACgkQnvQgOdby
QH2Q0g//UwNaa+Vr/RJfPCv4WfmutW8hism6pbveH1OKQ7bgpoQYzQWYhhdAYhI/
mksFNWBrBTaIiFNfKYLPEeLwypv0L27jkiw7cGri9obi44MJh/J1XMryk40UFpTl
NlM5ri/9fNxoKhNQ2Fs2f7CsqB+5NjW8hdrtlIX4TJ1r4a3lYKZBdpsmuxDZ6JNS
vkprPRJHPoNjZLQhw6JmPekvCQ+Wf6xpdjWS/kgjv9P6b+EPU8Xg63bF/wnPPEEj
b1gT71YysqiJcxraVmafS4WGStdzQvlYfMZAaFqJ5mn5eFNzTcaAHBSel1uJwWSD
W5O2l6c9pbFH8998JK1Ict/ldzx+Lt31h2kOfWlokGsJV0XgtPEk9OuI4tl5ZAXZ
arw65rm6b+hBZEwzF8fcDtgpupU80an/A8No0DYz+I4huK4hOmuUfP+tglrWBF06
2qQTAvJy+56Drkt3dQdg3tqRMugakYPxqFbs+XQMjKh9FXuxOc+Gez4o41Oz03PC
Pld3UMzRgXPX5FOkPMgjxkKuU/3ou9UaH1M5oMw7wrfz4T5TR7tocve9PSKItSW3
Q3I/v1kVd5qYu7euvL3ZQguW96YZiPyRaw+PMiCal1hhhtfwDuVumkRQVup+qdAh
phhC3NjM4DaFuDlzAtABZFDrZ0c13K0mjVrIdAXUDFdg9DAMJM4=
=ZSDk
-----END PGP SIGNATURE-----

--cS1F8NUiZ7pO6wdi--