Date: Sat, 4 Nov 2023 14:20:51 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Michael Banck <mbanck@gmx.net>, David Burns <david.burns@fedex.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Version 14/15 documentation Section "Alter Default Privileges"
Message-ID: <ZUaLgyKdfWeh6nlj@momjian.us>
References: 
 <LV2PR12MB5725F7C1B8EB2FC38829F276E7399@LV2PR12MB5725.namprd12.prod.outlook.com>
 <4a6f157edc4ae38a2050a5893e6729cbb98113bc.camel@cybertec.at>
 <f898e097dbe5e718ec1a6e977d4dda79a6548abb.camel@cybertec.at>
 <a6671d5651e64fceff340c68dbdc41a9c5098748.camel@cybertec.at>
 <653b841d.a70a0220.17f72.2c12@mx.google.com>
 <7de5f33f49a91d7b30b8c01fe46fc280713ebae1.camel@cybertec.at>
 <653cce08.050a0220.a10fb.7878@mx.google.com>
 <ZUUlmpxzsZMSZ7N_@momjian.us>
 <b227432f87266b680fd6f31e37b202b2fae5d9b6.camel@cybertec.at>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="D0U27sCFhqtKyG04"
Content-Disposition: inline
In-Reply-To: <b227432f87266b680fd6f31e37b202b2fae5d9b6.camel@cybertec.at>
Archived-At: 
 <https://www.postgresql.org/message-id/ZUaLgyKdfWeh6nlj%40momjian.us>
Precedence: bulk


--D0U27sCFhqtKyG04
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Nov  4, 2023 at 07:05:28AM +0100, Laurenz Albe wrote:
> On Fri, 2023-11-03 at 12:53 -0400, Bruce Momjian wrote:
> > I have developed the attached patch on top of the alter default patch I
> > just applied.  It is more radical, making FOR ROLE clearer, and also
> > moving my new FOR ROLE text up to the first paragraph, and reordering
> > the paragraphs to be clearer.
> > 
> > I think this is too radical for backpatch to 11/12, but I think
> > 16/master makes sense after the minor releases next week.
> 
> I think it is a good idea to move part of the text to a new paragraph.

Yeah, kind of radical but I think it needed to be done.

> > --- a/doc/src/sgml/ref/alter_default_privileges.sgml
> > +++ b/doc/src/sgml/ref/alter_default_privileges.sgml
> > @@ -90,23 +90,14 @@ REVOKE [ GRANT OPTION FOR ]
> > [...]
> > +   As a non-superuser, you can change default privileges only for yourself
> > +   and for roles that you are a member of.  These privileges are not
> > +   inherited, so member roles must use <command>SET ROLE</command> to
> > +   access these privileges, or <command>ALTER DEFAULT PRIVILEGES</command>
> > +   must be run for each member role.  Privileges can be set globally
> > +   (i.e., for all objects created in the current database), or just for
> > +   objects created in specified schemas.
> 
> That this paragraph is not clear enough about who gets the privileges and
> who creates the objects, and that is one of the difficulties in understanding
> ALTER DEFAULT PRIVILEGES.

Yes, I like your new paragraphs better than I what I had.

> This is downright wrong; the "target_role" will *not* be assigned any
> privileges.
> 
> Perhaps:
> 
>  <para>
>   Default privileges are changed only for objects created by
>   <replaceable>target_role</replaceable>.  If <literal>FOR ROLE</literal>
>   is omitted, the current role is assumed.
>  </para>

Yes, I see your point.  Updated patch attached.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.

--D0U27sCFhqtKyG04
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="role.diff"

diff --git a/doc/src/sgml/ref/alter_default_privileges.sgml b/doc/src/sgml/ref/alter_default_privileges.sgml
index 8a6006188d..4c93bdb884 100644
--- a/doc/src/sgml/ref/alter_default_privileges.sgml
+++ b/doc/src/sgml/ref/alter_default_privileges.sgml
@@ -90,23 +90,24 @@ REVOKE [ GRANT OPTION FOR ]
   <para>
    <command>ALTER DEFAULT PRIVILEGES</command> allows you to set the privileges
    that will be applied to objects created in the future.  (It does not
-   affect privileges assigned to already-existing objects.)  Currently,
-   only the privileges for schemas, tables (including views and foreign
-   tables), sequences, functions, and types (including domains) can be
-   altered.  For this command, functions include aggregates and procedures.
-   The words <literal>FUNCTIONS</literal> and <literal>ROUTINES</literal> are
-   equivalent in this command.  (<literal>ROUTINES</literal> is preferred
-   going forward as the standard term for functions and procedures taken
-   together.  In earlier PostgreSQL releases, only the
-   word <literal>FUNCTIONS</literal> was allowed.  It is not possible to set
-   default privileges for functions and procedures separately.)
+   affect privileges assigned to already-existing objects.)   Privileges can be
+   set globally (i.e., for all objects created in the current database), or
+   just for objects created in specified schemas.
+  </para>
+
+  <para>
+   As a non-superuser, you can change default privileges only on objects created
+   by yourself or by roles that you are a member of.  If you alter the default
+   privileges for a role, only objects created by that role will be affected.
+   It is not sufficient to be a member of that role; member roles must use
+   <command>SET ROLE</command> to assume the identity of the role for which
+   default privileges were altered.
   </para>
 
   <para>
-   You can change default privileges only for objects that will be created by
-   yourself or by roles that you are a member of.  The privileges can be set
-   globally (i.e., for all objects created in the current database),
-   or just for objects created in specified schemas.
+   There is no way to change the default privileges for objects created by
+   any role.  You have run <command>ALTER DEFAULT PRIVILEGES</command> for all
+   roles that can create objects whose default privileges should be modified.
   </para>
 
   <para>
@@ -118,6 +119,19 @@ REVOKE [ GRANT OPTION FOR ]
    <command>ALTER DEFAULT PRIVILEGES</command>.
   </para>
 
+  <para>
+   Currently,
+   only the privileges for schemas, tables (including views and foreign
+   tables), sequences, functions, and types (including domains) can be
+   altered.  For this command, functions include aggregates and procedures.
+   The words <literal>FUNCTIONS</literal> and <literal>ROUTINES</literal> are
+   equivalent in this command.  (<literal>ROUTINES</literal> is preferred
+   going forward as the standard term for functions and procedures taken
+   together.  In earlier PostgreSQL releases, only the
+   word <literal>FUNCTIONS</literal> was allowed.  It is not possible to set
+   default privileges for functions and procedures separately.)
+  </para>
+
   <para>
    Default privileges that are specified per-schema are added to whatever
    the global default privileges are for the particular object type.
@@ -136,12 +150,9 @@ REVOKE [ GRANT OPTION FOR ]
     <term><replaceable>target_role</replaceable></term>
     <listitem>
      <para>
-      The name of an existing role of which the current role is a member.
-      Default access privileges are not inherited, so member roles
-      must use <command>SET ROLE</command> to access these privileges,
-      or <command>ALTER DEFAULT PRIVILEGES</command> must be run for
-      each member role.  If <literal>FOR ROLE</literal> is omitted,
-      the current role is assumed.
+      Change default privileges for objects created by
+      <replaceable>target_role</replaceable>;  if omitted, the current
+      role is modified.
      </para>
     </listitem>
    </varlistentry>

--D0U27sCFhqtKyG04--