Date: Mon, 13 Nov 2023 14:53:55 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	"zhoushulin1992@gmail.com" <zhoushulin1992@gmail.com>,
	"pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>
Subject: Re: 'pg_global' cannot be used as default_tablespace.
Message-ID: <ZVJ-003PHyJm0wUo@momjian.us>
References: <160499688847.25495.8682880307938679648@wrigleys.postgresql.org>
 <ZULN_DUmssiXednO@momjian.us>
 <CAKFQuwY+s2BC2jZ4ZVwM7j6BXJ0zOCecOOfEM7_0szvVY_9deA@mail.gmail.com>
 <2878751.1698877957@sss.pgh.pa.us>
 <ZULWiAskl5qtYZN8@momjian.us>
 <2883160.1698880368@sss.pgh.pa.us>
 <ZULgo051ezZMnWvM@momjian.us>
 <ZUOndqOz89dpD8T6@momjian.us>
 <3025455.1698933534@sss.pgh.pa.us>
 <ZUO7hd9OVzhGmqFn@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZUO7hd9OVzhGmqFn@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/ZVJ-003PHyJm0wUo%40momjian.us>
Precedence: bulk

On Thu, Nov  2, 2023 at 11:08:53AM -0400, Bruce Momjian wrote:
> On Thu, Nov  2, 2023 at 09:58:54AM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > I found a cleaner improvement, attached.
> > 
> > OK by me.  Maybe that doesn't make the point strongly enough,
> > but we can hope it's enough.
> 
> Agreed.  I thought last night about the sentence and realized when we
> say pg_global is used for shared system catalogs, we are not saying
> other object can't also be put there, so the "only" seemed required, and
> once I added that, the second sentence fragment seemed unnecessary.
> 
> Plus, this report is from three years ago and I haven't seen any other
> reports since then.
> 
> I also prefer manage-ag.sgml because we already talk about pg_global
> there, and hopefully users of GUC tablespaces and CREATE TABLE will see
> it there, or at least look for it when they get the error on creation.

Patch applied to master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.