Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 19 Jul 2024 11:10:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: =?utf-8?B?5pel5ZCR5YWF?= <mitsuru.hinata.5432@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: A minor bug in the doc of "SQL Functions Returning Sets" in
 xfunc.sgml.
Message-ID: <ZpnLEUUNxy-LP_lY@paquier.xyz>
References: 
 <CAF-2iM_9-2a8PijHoHbS6ZFFV=tziOx8TDo4j+YGDAbsTApk4w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="y05iml5wMh9HCdBG"
Content-Disposition: inline
In-Reply-To: 
 <CAF-2iM_9-2a8PijHoHbS6ZFFV=tziOx8TDo4j+YGDAbsTApk4w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZpnLEUUNxy-LP_lY%40paquier.xyz>
Precedence: bulk


--y05iml5wMh9HCdBG
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 19, 2024 at 10:46:04AM +0900, =E6=97=A5=E5=90=91=E5=85=85 wrote:
> I have found executable examples that do not work correctly
> in the doc of "SQL Functions Returning Sets" in xfunc.sgml.
> So I fixed the examples as follows.
> - Changed CREATE TABLE tab
>   '(y int, z int)' to '(x int, y int, z int)'
> - Changed INSERT INTO tab
>   '(1, 2), (3, 4), (5, 6), (7, 8)'
>   to '(1, 2, 3), (4, 5, 6), (7, 8, 9), (10, 11, 12)'
> - Changed CREATE FUNCTION sum_n_product_with_tab
>   '(x int, OUT sum int, OUT product int)'
>   to '(int, OUT sum int, OUT product int)'
> - Changed CREATE FUNCTION sum_n_product_with_tab
>   'SELECT $1 + tab.y, $1 * tab.y FROM tab;'
>   to 'SELECT $1 + tab.x, $1 * tab.x FROM tab;'
> - Changed result of "SELECT * FROM sum_n_product_with_tab(10);"
>=20
> The above will improve the results of examples as follows in this chapter.
>=20
> Do you think?

Not sure that this is worth changing.  The examples work OK when taken
in isolation or are able to demonstrate the point they want to show.
In short, not all these queries are here to be compatible with the
contents in the same area.  See for example the case of the "nodes"
table on the same page, created nowhere.  "tab" is just a more generic
table name that's more spread.
--
Michael

--y05iml5wMh9HCdBG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaZyxEACgkQnvQgOdby
QH0BhQ/+OLR5WbgmAPHxQmJ3WWh5FK5UB1xu5NljPrsnUKKtBowXyyGeQeFnETlj
O+LV0zdcCbf3wbJPvkDDIXyhgZO6sse8rfSuW8r5XhkdlYFxll4BIopmw5UOZdvq
++lXjcaKUw1J+7VveRWCwwUpMQRMeZJdrmsvcAw74zvGKuEgDN9g31lCZnvcwTvZ
dDElxdzyAx3DLelcpOaLDA2dnStu2SVbquEy+3wyRZmRryzJ4LkeaqObe6ydqxf/
Prpwrrh2d75fxqiNa7eNNsWloE9+LDBpclo3Za8WIV+SukWKCUvB/sYNxIMfnHC5
GVD44TZgySo/ju5wzjZHSO7j99r85QAk8zwEhRPBCQzBNsrd+3IhC5h4petWMc6h
EO395rE9CAVP9+N6QuY6XEF+L2pIldA7DewNW7m9m9H95bikUnCUnkVaFnkXMT1k
CS64P1EhuSwNNQdIlovO9azXIfAHxAmWNp3OJ1eo5KF012BCvesJbXtd3jmQYlIz
tVq371klrujkhl3KDc1TLCu1QqXkBgNkUe3dg2FiCEQbmVL50DmuQ3C55IAEOicE
J0qiQPRSB+nf8HzZg37hwtxZGZqM4A268HzZvcUyTqDilbGd9QVAaNa5vmCIwvUU
8xWLH3YzlQ1IFE3AxQi80KPf9ezldmMNGfgQTbXRRwUmNIV10sk=
=QfVN
-----END PGP SIGNATURE-----

--y05iml5wMh9HCdBG--