Date: Mon, 19 Aug 2024 18:27:38 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Euler Taveira <euler@eulerto.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
	PostgreSQL-documentation <pgsql-docs@postgresql.org>,
	Peter Eisentraut <peter@eisentraut.org>
Subject: Re: pg_createsubscriber clarification
Message-ID: <ZsPG2h9-VsjcZmnF@momjian.us>
References: <ZqX_4J-nFTQtmj6K@momjian.us>
 <CAD21AoCKqU8GPoAKA3V_-JD40tXR6VndekCV0Cx_9RMsGRVoYQ@mail.gmail.com>
 <1802dbe8-d136-4ea3-bc31-bffc41b2cd27@app.fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1802dbe8-d136-4ea3-bc31-bffc41b2cd27@app.fastmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZsPG2h9-VsjcZmnF%40momjian.us>
Precedence: bulk


Thanks, patch applied to PG 17 and master.

---------------------------------------------------------------------------

On Tue, Jul 30, 2024 at 06:02:51PM -0300, Euler Taveira wrote:
> On Sun, Jul 28, 2024, at 1:17 PM, Masahiko Sawada wrote:
> 
>     I think the term "synchronization phase" comes from the description in
>     "29.8.1. Initial Snapshot" section[1].
> 
> 
> Yes.
> 
> 
>     https://www.postgresql.org/docs/17/logical-replication-architecture.html#
>     LOGICAL-REPLICATION-SNAPSHOT
> 
>     How about the following?
> 
>     The main difference between the logical replication setup and
>     pg_createsubscriber is how they synchronize table data.
>     pg_createsubscriber doesn't copy the initial table data because it
>     uses the tables with their initial data on the target server. It only
>     does the synchronization phase, which ensures each table is brought up
>     to a synchronized state by applying changes using standard logical
>     replication.
> 
> 
> I slightly modified your proposal in the attached patch.
> 
> Thoughts?
> 
> 
> --
> Euler Taveira
> EDB   https://www.enterprisedb.com/
> 

> diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml
> index 87a9d3db28e..6ebf918b636 100644
> --- a/doc/src/sgml/ref/pg_createsubscriber.sgml
> +++ b/doc/src/sgml/ref/pg_createsubscriber.sgml
> @@ -57,9 +57,10 @@ PostgreSQL documentation
>    <para>
>     After a successful run, the state of the target server is analogous to a
>     fresh logical replication setup.  The main difference between the logical
> -   replication setup and <application>pg_createsubscriber</application> is the
> -   initial data copy.  It does only the synchronization phase, which ensures
> -   each table is brought up to a synchronized state.
> +   replication setup and <application>pg_createsubscriber</application> is how
> +   the data synchronization is done. <application>pg_createsubscriber</application>
> +   does not copy the initial table data. It does only the synchronization phase,
> +   which ensures each table is brought up to a synchronized state.
>    </para>
>  
>    <para>


-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.