Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 13 Sep 2024 07:39:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Greg Sabino Mullane <htamfids@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
	pgsql-docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Table rewrite supporting functions for event triggers
Message-ID: <ZuNtkd5IJ0TipHzo@paquier.xyz>
References: 
 <CAKAnmmL+Z6j-C8dAx1tVrnBmZJu+BSoc68WSg3sR+CVNjBCqbw@mail.gmail.com>
 <718fcf4a067b576b501bd5b18b54a1fdc4fda639.camel@cybertec.at>
 <CAKAnmm+SfSEg+bmWqT5Q9BSTU3FGaSquVebrQ+8jg3Dq-_1vxg@mail.gmail.com>
 <CAKAnmm+NKVhZMjNN8okbPHXMxSb0Ngqhxgt4hEMGU=RWq9fnKA@mail.gmail.com>
 <c264f34792b17f5bd30133071cfa252919bf5323.camel@cybertec.at>
 <ZuEx_09-ohYExkJG@paquier.xyz>
 <CAKAnmmJ-DXh4QDjS8Aiz8SBxDWrcj1Epq54byb8T_035nTX2JQ@mail.gmail.com>
 <ZuJdSA9U5OmgagbS@paquier.xyz>
 <CAKAnmmLOq8DPfd14Wj+gmn8vH4nUY0_NrWiHL0gQGxXj2SCW4g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mv9uToz11onIqtnN"
Content-Disposition: inline
In-Reply-To: 
 <CAKAnmmLOq8DPfd14Wj+gmn8vH4nUY0_NrWiHL0gQGxXj2SCW4g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZuNtkd5IJ0TipHzo%40paquier.xyz>
Precedence: bulk


--mv9uToz11onIqtnN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 12, 2024 at 08:52:00AM -0400, Greg Sabino Mullane wrote:
> I do like the simplicity of the bitmap:
>=20
> if (reason & 1)
>   print "Table has changed from logged to unlogged"
> if (reason & 2)
>   print "Default has been changed"
>=20
> versus with text[]:
>=20
> foreach reason in tablereason[]
>   if reason.match_exact("ALTER_PERSISTENCE")
>     print "Table has changed from logged to unlogged"
>   if reason.match_regex("DEFAULT")
>     print "Default has been changed"
> ...

Okay.  I am not going to be annoying with compatibility, then :D

> My initial reaction was that this is indeed a rare case, and to avoid
> putting that level of code detail in the docs. Your argument is a good on=
e,
> but it still feels wrong to put that there. Yes, this puts a little more
> onus on future developers, but updating the docs is already a core
> requirement for patches.
>=20
> (On reflection, maybe reverse it - put a code comment in event_trigger.h
> reminding people to also update the docs? But again, that's seems like
> something obvious anyway for someone making that change.)

I am not so sure, TBH.  One example: I know these values in
tablecmds.c for some time because that's an area I tend to focus on
for bug fixes, but forgot entirely about the SQL function in event
triggers that feed on it until I found your post.  A comment in
event_trigger.h to mention the doc update would work for me.  That
would be impossible to miss.
--
Michael

--mv9uToz11onIqtnN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbjbZEACgkQnvQgOdby
QH1TVQ/8C2P8M9cozvSbekyDVMIkzJLsy0SVrKeLcflkAtC2Pcqfb/WiIgsDIz6y
Hehj4Y2mtLlv7IMEJVKh689p95JeshszdcHuSi819BVVOV0vHRYGZK6hpCsUcz+S
ZiUzU/to+BqSz6IeWKtroOkCTao19v+xIutZWfvTHcFAs7PQ+h2/IWJ3893cVVHp
N601Q8/+nj0D82499FiSUGrlcWq+p5PJzA+6A9p42F8ecwxa4gySisuHO+7eS5WZ
OxILY+Feg/GAFLJmuw55CvIKMR1QaP5NCSVX29MFWsekXby2EqYZwN6lOhQfIIZy
AXnw72Ex+nYUeD6lGabiRI5/44Q0BLGOA3wEr2xqBpCfiq5ifCbQspAPcwwp1NB4
ROilUb4cFQRhmAOrmGsfztEuPz+wg01LZX2JVQZY7SFmwAlJoQpT42PDEwvCCrD5
vGB5KCVHQsUqARuIoScEnTbK/lmBoxoupzdW92UCgnOFeeGkY/QSYFIh27jSA78M
A374J9gzZdWTR4kx2oe73fhk6qaDTxWvrocXoywPHk2wpajC2BcXRVfV4lBORL91
xAoJ0y2J3hpXMiZOGGo12+3FQ2r5drmriSN44qSoNHxZHnn/kMwu5Cex58ko53/U
Maw/RHmlMuE36V2e7LC49dS7CUywzXVrzT7qb5nGTDNGxErNAdQ=
=WSRz
-----END PGP SIGNATURE-----

--mv9uToz11onIqtnN--