Date: Mon, 14 Oct 2024 19:21:32 -0400
From: Bruce Momjian <bruce@momjian.us>
To: pgsql-docs@lists.postgresql.org
Subject: Re: Add mention to related system catalog functions on Tablespaces
 documentation pages.
Message-ID: <Zw2nfPG4ikW-MFDf@momjian.us>
References: <172609721070.1128084.6724666076293146476@wrigleys.postgresql.org>
 <Zw2mJoNMpyS-aNkl@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="PbWNuJThbnTvpzlG"
Content-Disposition: inline
In-Reply-To: <Zw2mJoNMpyS-aNkl@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/Zw2nfPG4ikW-MFDf%40momjian.us>
Precedence: bulk


--PbWNuJThbnTvpzlG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 14, 2024 at 07:15:50PM -0400, Bruce Momjian wrote:
> On Wed, Sep 11, 2024 at 11:26:50PM +0000, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> > 
> > Page: https://www.postgresql.org/docs/16/manage-ag-tablespaces.html
> > Description:
> > 
> > The tablespaces documentation page seems to be missing a mention to the
> > following functions:
> > pg_tablespace_databases
> > pg_tablespace_location
> > 
> > These are documented in
> > https://www.postgresql.org/docs/current/functions-info.html#FUNCTIONS-INFO-CATALOG,
> > but I think it would be nice to add at least a brief mention (or link) to
> > them in the main tablespace docs. The following query is especially helpful
> > when troubleshooting issues with tablespaces:
> > 
> > postgres=# SELECT *, pg_tablespace_location(oid) FROM pg_tablespace;
> > 
> > It would be beneficial, in my opinion, to use it as an additional example to
> > the one that is currently shown.
> 
> Yes, very good points.  I have developed the attached patch which I
> think achieves the goals you mentioned.  I plan to apply the patch for
> master/PG 18.
> 
> I also removed the unnecessary mention of PG 9.1.
> 
> Seems the reply email address is g***@gmail.com, which seems like some
> kind of mistake.

Sorry, patch attached.  Invalid email address removed.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"

--PbWNuJThbnTvpzlG
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="tablespace.diff"

diff --git a/doc/src/sgml/manage-ag.sgml b/doc/src/sgml/manage-ag.sgml
index a8a70a1fc42..fe4cb4410cd 100644
--- a/doc/src/sgml/manage-ag.sgml
+++ b/doc/src/sgml/manage-ag.sgml
@@ -530,9 +530,11 @@ CREATE TABLE foo(i int);
    <link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname>
    </link> system catalog, for example
 <synopsis>
-SELECT spcname FROM pg_tablespace;
+SELECT spcname, spcowner::regrole, pg_tablespace_location(oid) FROM pg_tablespace;
 </synopsis>
-   The <xref linkend="app-psql"/> program's <literal>\db</literal> meta-command
+   It is possible to find which databases use which tablespaces;
+   see <xref linkend="functions-info-catalog-table"/>.  The <xref
+   linkend="app-psql"/> program's <literal>\db</literal> meta-command
    is also useful for listing the existing tablespaces.
   </para>
 
@@ -541,10 +543,7 @@ SELECT spcname FROM pg_tablespace;
    point to each of the non-built-in tablespaces defined in the cluster.
    Although not recommended, it is possible to adjust the tablespace
    layout by hand by redefining these links. Under no circumstances perform
-   this operation while the server is running. Note that in PostgreSQL 9.1
-   and earlier you will also need to update the <structname>pg_tablespace</structname>
-   catalog with the new locations. (If you do not, <literal>pg_dump</literal> will
-   continue to output the old tablespace locations.)
+   this operation while the server is running.
   </para>
 
  </sect1>

--PbWNuJThbnTvpzlG--