Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 29 Oct 2024 15:40:48 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Greg Sabino Mullane <htamfids@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
	pgsql-docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Table rewrite supporting functions for event triggers
Message-ID: <ZyCDcO8ZigR-41gL@paquier.xyz>
References: 
 <CAKAnmmL+Z6j-C8dAx1tVrnBmZJu+BSoc68WSg3sR+CVNjBCqbw@mail.gmail.com>
 <718fcf4a067b576b501bd5b18b54a1fdc4fda639.camel@cybertec.at>
 <CAKAnmm+SfSEg+bmWqT5Q9BSTU3FGaSquVebrQ+8jg3Dq-_1vxg@mail.gmail.com>
 <CAKAnmm+NKVhZMjNN8okbPHXMxSb0Ngqhxgt4hEMGU=RWq9fnKA@mail.gmail.com>
 <c264f34792b17f5bd30133071cfa252919bf5323.camel@cybertec.at>
 <ZuEx_09-ohYExkJG@paquier.xyz>
 <CAKAnmmJ-DXh4QDjS8Aiz8SBxDWrcj1Epq54byb8T_035nTX2JQ@mail.gmail.com>
 <ZuJdSA9U5OmgagbS@paquier.xyz>
 <CAKAnmmLOq8DPfd14Wj+gmn8vH4nUY0_NrWiHL0gQGxXj2SCW4g@mail.gmail.com>
 <ZuNtkd5IJ0TipHzo@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="uIKfOY493caoaKWw"
Content-Disposition: inline
In-Reply-To: <ZuNtkd5IJ0TipHzo@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/ZyCDcO8ZigR-41gL%40paquier.xyz>
Precedence: bulk


--uIKfOY493caoaKWw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 13, 2024 at 07:39:13AM +0900, Michael Paquier wrote:
> I am not so sure, TBH.  One example: I know these values in
> tablecmds.c for some time because that's an area I tend to focus on
> for bug fixes, but forgot entirely about the SQL function in event
> triggers that feed on it until I found your post.  A comment in
> event_trigger.h to mention the doc update would work for me.  That
> would be impossible to miss.

My apologies for the delay in replying here.  I've looked back at your
proposal in 0002 to mention the two functions in the main section for
event triggers and to add a description of the reson values in the
bitmap.  After adding a comment in event_trigger.h to tell that the
documentation needs to be kept in sync, the result looked OK so I have
applied that down to 13.

1ad23335f36b got in the way for 12 with some conflicts.  As it is
going to be EOL in a few days, it does not really matter much.
--
Michael

--uIKfOY493caoaKWw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcgg3AACgkQnvQgOdby
QH11Nw/+LoIFR2lbrILfC6m+RE2gdZEMmtpSA6Q5f670aItMUhwAPYWjtFGk4Ris
mp+bKaDIgur1ItsSYcauesvnnkSCdzMSGBDmQ9tXHFzffsQAC1T8rumcOHmb0HYa
CuasqONIzUUwaZucChf6+pcDAbgBjiu+E7iRBoE6KW+wEkBOkmEl8LvFA82Voyd9
WMpzy/sKdEb5fawHh/88xYcP+fjWqpkrOCg2do9D8a0AMDL28VD54uaKhb9zG6a6
Io8PP3ZNLThDUSWsm4shMts/WE6Eg82Nvfora2xyiFW9CKQZfIvSD4hm33sazCLy
zNhidFOzVltdZuOMfLWpHK8bTISSBe+C4pg68kefh5L/rj3dbH6X4sN1h+vMO31F
dSR8Zf7+C7MP0We3Y2PM3Z0yrkhVNf5mkJek4IzOTAI7m+919/IdAgH1cfF3QzkN
+POhKpn7WAostA35cE3Dv43XdTUyvrrR1FHKCvz1Bf9EPZeClZhUdsG7WPc65zBV
m/ZeCMY4Sj58hzfZFsRZVGZOt0vyxM1yspYOR/zJhWuiqxQrT1KRN5m6IqAzzPe3
uZx58D90u1Ut/fyDjj0Gd9O2oW6XrSnHvDOotKbBxAG9dYddsJ03Fd11RnZqAT0A
7bfmx0UXsDrOOz3zJHvusRVjzMvUgUz0MUaYxIbgenicWpwQBRE=
=aWuY
-----END PGP SIGNATURE-----

--uIKfOY493caoaKWw--