Date: Mon, 4 Nov 2024 14:52:57 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL-documentation <pgsql-docs@postgresql.org>,
	Tatsuo Ishii <ishii@postgresql.org>
Subject: Re: pgsql: doc: improve build for non-Latin1 characters
Message-ID: <ZykmGcsFFCBZMaVc@momjian.us>
References: <E1t6unt-003TTk-62@gemulon.postgresql.org>
 <2c5dd601-b245-4092-9c27-6d1ad51609df@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2c5dd601-b245-4092-9c27-6d1ad51609df@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ZykmGcsFFCBZMaVc%40momjian.us>
Precedence: bulk

On Mon, Nov  4, 2024 at 08:02:18AM +0100, Peter Eisentraut wrote:
> I'm surprised this was committed.  I don't think there was consensus that

(thread moved to docs)

Well, I posted the final patch on October 15, and though the thread was
active with comments, no one had any feedback for my patch so I assumed
it was acceptable.

> this is the right direction.  Moreover, this touched a couple of files that
> it shouldn't have:
> 
> doc/src/sgml/images/genetic-algorithm.svg is a generated file that shouldn't
> be changed directly.  In fact, adding the *.svg files to the check-nbsp
> target is therefore also wrong.

Good point.  I have removed the SVG check from the Makefile.  I also
figured out the UTF8 non-Latin1 spaces came from
doc/src/sgml/images/genetic-algorithm.gv:

        a4 -> a5[xlabel="false   ", fontsize=10];
        a4 -> end[xlabel="true  ",  fontsize=10];

Are those spaces before the close quotes expected?  Maybe they are used
to distance the text from an image.

> The chunk in doc/src/sgml/stylesheet-man.xsl was copied from the upstream
> stylesheets, and changing it causes extra differences that would make future
> maintenance harder.  Also, man stylesheets have by definition nothing to do
> with the pdf builds, so why do they need to be touched?

Wow, I had no idea that UTF8 quotes would actually work in XML files. 
If you think they actually work we can put them back but I don't know
how to test if they are working properly or not.  I assume ASCII double
quotes do work.

I am thinking Tatsuo's idea of using iconv to check files with any
non-ASCII characters is a better approach and will reply to that thread.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"