Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN2RH-0000af-Eg for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 23:52:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lN2RG-0007RT-B8 for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 23:52:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN2RG-0007RM-4j for pgsql-hackers@lists.postgresql.org; Thu, 18 Mar 2021 23:52:26 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lN2RC-0005yZ-Id for pgsql-hackers@lists.postgresql.org; Thu, 18 Mar 2021 23:52:25 +0000 Received: by mail-ej1-x62a.google.com with SMTP id u9so6732677ejj.7 for ; Thu, 18 Mar 2021 16:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vms3wJ0VN2C4z7347K9VXu3QCGkSnIaJN3j9hfHN468=; b=XEaPLVqEdrzf7BvsgIYaLbcG7vgPJ3OoNt6gwANszlPy/6hLGbHu7CbyRXpOzPtti5 J8GDR4tfnbadRpLLkI6DYQoRqcOMECEwZT9hKea3k0gUkNGu9p8smeCf/hufXCSQjm3P j+crCP8m88Fr9lEuz/4LMwkQajv8zuTynl9XDvFy2clLXJ5cjuphTULzU6ApnzM6CFXB s+Mh7pbpjnzrZU+i46UOm8RFbcto5dhlhEble+1Q3PAJDhyAPHANuma00j/PmdHQHpfc aEr8OFdoYOxtaWhr3bItny9vKEMqs9YYV3cu+ce2RME/1oWpzmrBxeMuWZNH4JqAipuI xHcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vms3wJ0VN2C4z7347K9VXu3QCGkSnIaJN3j9hfHN468=; b=cWKgg3gnGmub0fkqIMJBHUTRjKlDkc80NIn0VZoMvLi+6Dn5kPJUmUu60fCF7Dym1Z 0QeMTh4Gp0O3zE0w30/z9RvPi+rtymtg5nTFuAl6G6qGrVDXP42eXh+/nDRvYwxN+fXX UjqR7vCQB7g1xXO6A/ZkdZVjM/GqyQuhTENB5+K9BqG/UdMsl1AAEAmQ8QtL5OkO80Y3 8go7DvSpqu0FyTjRQ7obzGsFgiirKF2secgvnCJummCm3sMthoz8dYB2SdWWaXKSIe6x rhLGqqYOPWfJ+se5+EOcsQXhmVBvbFbe8IBMhxeMZ67OekKrjufTox8kFgFyDRApMP/p QzzQ== X-Gm-Message-State: AOAM533mT5lLPo+NAsHHlPnXzdN8x+tyvyxiZJWDyM4kgKpyYwxziBIp i2zFjf2Uv2MPB/SAADRdugQr/KLuLVPL/tKnn8URAgHzKZeT8pdOKTK21Z06ljAadZB8crEC1CY a9JMYRnU5cKz6uZyzRQpfEYcnvPyeNsYJEVchqv+TsftqsWzTdmh4Rk0LX+qm7A+UsJm5YHyuMD SJjo8vjwXnrcrTB/wLU/eLQ+R/CeStuSl6HDIpRd5vhIFnTsK1fu2N X-Google-Smtp-Source: ABdhPJzuXW+N0dqd3qLvjcDlx5zChQBQnZHP8aNsOt/lObyHNCeX3XsS0BiebYcLWA0yRS/SJCBhCA== X-Received: by 2002:a17:906:70d:: with SMTP id y13mr1230289ejb.170.1616111541523; Thu, 18 Mar 2021 16:52:21 -0700 (PDT) Received: from [10.137.0.20] (ip-86-49-253-127.net.upcbroadband.cz. [86.49.253.127]) by smtp.gmail.com with ESMTPSA id f21sm2721854ejw.124.2021.03.18.16.52.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 16:52:20 -0700 (PDT) Subject: Re: GROUP BY DISTINCT To: Tom Lane Cc: Thomas Munro , Vik Fearing , Georgios Kokolatos , PostgreSQL Hackers , Erik Rijkers References: <161469758801.29967.4455067072614569957.pgcf@coridan.postgresql.org> <4294e82f-a134-5dbb-d9d6-03d72dce2e1e@postgresfriends.org> <3817d5ec-f3e4-e4b9-d169-271ae5d3cbe4@postgresfriends.org> <8c44df08-bb64-3d78-da1a-d24b7c9db39d@enterprisedb.com> <7137947a-87be-d04a-bf91-f42e47520daa@enterprisedb.com> <35077b31-2d62-1e31-0e2e-ddb52d590b73@enterprisedb.com> <3818384.1616106942@sss.pgh.pa.us> <3828009.1616109022@sss.pgh.pa.us> <3858396.1616110003@sss.pgh.pa.us> From: Tomas Vondra Message-ID: Date: Fri, 19 Mar 2021 00:52:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <3858396.1616110003@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/19/21 12:26 AM, Tom Lane wrote: > I wrote: >> This is gcc 4.5, but hopefully whatever shuts it up will also work on 4.7. >> I'll work on figuring that out. > > Actually, the problem is pretty obvious after comparing this use > of foreach_delete_current() to every other one. I'm not sure why > the compiler warnings are phrased just as they are, but the fix > I just pushed does make 4.5 happy. > Thanks! Yeah, that looks obvious. Funny the older compilers noticed this, not the new fancy ones. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company