Subject: Re: Change wording for PG_MODULE_MAGIC inclusion
To: Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>
References: <20170830143558.sb42walb2tztlfh4@alvherre.pgsql>
 <27898.1504104716@sss.pgh.pa.us>
 <E2FCBAD9-A88B-416D-B4CF-703654B05F5C@yesql.se>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
 pgsql-docs <pgsql-docs@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <a5b8e59b-f23c-535f-896b-3594b4120622@2ndquadrant.com>
Date: Wed, 30 Aug 2017 22:42:24 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <E2FCBAD9-A88B-416D-B4CF-703654B05F5C@yesql.se>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

On 8/30/17 13:28, Daniel Gustafsson wrote:
>> On 30 Aug 2017, at 16:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> Uh, why would anybody be reading the pg10 docs in order to compile
>>> modules for 8.2?  I vote to just drop the suggestion that there needs to
>>> be an #ifdef guard altogether.
>>
>> +1 ... if you are reading the current docs, they're going to tell you
>> lots of things that won't work in 8.1.
> 
> Patch updated with dropping the #ifdef guard paragraph.  Also removed the
> mention of when the magic block was introduced as it seemed an odd piece of
> archaeology to keep around when the guard paragraph was removed.

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs