To: pgsql-docs@postgresql.org
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Subject: The order of columns about WAL activity in pg_stat_statements
Message-ID: <a6e68c83-0923-afe7-c1f2-5c5843a21687@oss.nttdata.com>
Date: Thu, 14 May 2020 00:11:22 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.8.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------018944669ABAE0CD874DAD72"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------018944669ABAE0CD874DAD72
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

https://www.postgresql.org/docs/devel/pgstatstatements.html

In pg_stat_statements docs, the columns about WAL activity are put
in the table in the order of wal_bytes, wal_records and wal_fpi. But
in the definition of pg_stat_statements view, wal_bytes is put last.
So I think that it's better to reorder those columns in a consistent
with the view definition. Patch attached. Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------018944669ABAE0CD874DAD72
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="pgss_docs.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="pgss_docs.patch"

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9wZ3N0YXRzdGF0ZW1lbnRzLnNnbWwgYi9kb2Mv
c3JjL3NnbWwvcGdzdGF0c3RhdGVtZW50cy5zZ21sCmluZGV4IGIxZDVmM2QxZGMuLmVkYWNk
YTk3MWYgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9wZ3N0YXRzdGF0ZW1lbnRzLnNnbWwK
KysrIGIvZG9jL3NyYy9zZ21sL3Bnc3RhdHN0YXRlbWVudHMuc2dtbApAQCAtMjY0LDE1ICsy
NjQsNiBAQAogICAgICAgPC9lbnRyeT4KICAgICAgPC9yb3c+CiAKLSAgICAgPHJvdz4KLSAg
ICAgIDxlbnRyeT48c3RydWN0ZmllbGQ+d2FsX2J5dGVzPC9zdHJ1Y3RmaWVsZD48L2VudHJ5
PgotICAgICAgPGVudHJ5Pjx0eXBlPm51bWVyaWM8L3R5cGU+PC9lbnRyeT4KLSAgICAgIDxl
bnRyeT48L2VudHJ5PgotICAgICAgPGVudHJ5PgotICAgICAgICBUb3RhbCBhbW91bnQgb2Yg
V0FMIGJ5dGVzIGdlbmVyYXRlZCBieSB0aGUgc3RhdGVtZW50Ci0gICAgICA8L2VudHJ5Pgot
ICAgICA8L3Jvdz4KLQogICAgICA8cm93PgogICAgICAgPGVudHJ5PjxzdHJ1Y3RmaWVsZD53
YWxfcmVjb3Jkczwvc3RydWN0ZmllbGQ+PC9lbnRyeT4KICAgICAgIDxlbnRyeT48dHlwZT5i
aWdpbnQ8L3R5cGU+PC9lbnRyeT4KQEAgLTI5MSw2ICsyODIsMTUgQEAKICAgICAgIDwvZW50
cnk+CiAgICAgIDwvcm93PgogCisgICAgIDxyb3c+CisgICAgICA8ZW50cnk+PHN0cnVjdGZp
ZWxkPndhbF9ieXRlczwvc3RydWN0ZmllbGQ+PC9lbnRyeT4KKyAgICAgIDxlbnRyeT48dHlw
ZT5udW1lcmljPC90eXBlPjwvZW50cnk+CisgICAgICA8ZW50cnk+PC9lbnRyeT4KKyAgICAg
IDxlbnRyeT4KKyAgICAgICAgVG90YWwgYW1vdW50IG9mIFdBTCBieXRlcyBnZW5lcmF0ZWQg
YnkgdGhlIHN0YXRlbWVudAorICAgICAgPC9lbnRyeT4KKyAgICAgPC9yb3c+CisKICAgICA8
L3Rib2R5PgogICAgPC90Z3JvdXA+CiAgIDwvdGFibGU+Cg==
--------------018944669ABAE0CD874DAD72--