Reply-To: arnaud.listes@codata.eu
Subject: Re: pg_upgrade --link on Windows
To: Adrian Klaver <adrian.klaver@aklaver.com>,
 Bruce Momjian <bruce@momjian.us>
Cc: PG-General Mailing List <pgsql-general@postgresql.org>
References: <8da3dbd9-7daf-5589-0cc8-0eede930a492@codata.eu>
 <20170609140724.GB21215@momjian.us>
 <a892509c-0eb4-42a4-1370-6cb0ac3bc1c3@codata.eu>
 <0405d125-929b-ab4a-b7be-d49c09e7c056@aklaver.com>
From: "Arnaud L." <arnaud.listes@codata.eu>
Message-ID: <a9320aea-1c9d-3e37-103e-88b7edcc2080@codata.eu>
Date: Fri, 9 Jun 2017 17:02:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <0405d125-929b-ab4a-b7be-d49c09e7c056@aklaver.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-general-owner@postgresql.org

Le 9/06/2017 à 16:55, Adrian Klaver a écrit :
> On 06/09/2017 07:39 AM, Arnaud L. wrote:
>> So maybe pg_upgrade uses hard-links (i.e. to files), and only the 
>> documentation is wrong by calling them junctions (i.e. soft links to 
>> files) ?
> 
> Looks that way. In file.c in ~/src/bin/pg_upgrade I see:
> 
> #ifdef WIN32
>    300 /* implementation of pg_link_file() on Windows */
>    301 static int
>    302 win32_pghardlink(const char *src, const char *dst)
>    303 {
>    304     /*
>    305      * CreateHardLinkA returns zero for failure
>    306      * http://msdn.microsoft.com/en-us/library/aa363860(VS.85).aspx
>    307      */
>    308     if (CreateHardLinkA(dst, src, NULL) == 0)
>    309     {
>    310         _dosmaperr(GetLastError());
>    311         return -1;
>    312     }
>    313     else
>    314         return 0;
>    315 }
>    316 #endif

Great !
So I did a full upgrade for nothing (just for safety), but that's good 
to know for next time !
Should this be submitted to postgresql-bugs, or is there something more 
specific to the documentation ?

Regards
--
Arnaud


-- 
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general