Date: Wed, 29 Oct 2025 17:25:43 -0400
From: Bruce Momjian <bruce@momjian.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>,
	Euler Taveira <euler@eulerto.com>, Erik Wienhold <ewie@ewie.name>,
	pgsql-docs@lists.postgresql.org
Subject: Re: Use uppercase keywords in foreign key tutorial
Message-ID: <aQKGVwVChafkfSub@momjian.us>
References: <82eb512b-8ed2-46be-b311-54ffd26978c4@ewie.name>
 <a5034028-3f97-4157-8fd2-6eb552ffaab8@app.fastmail.com>
 <0a9d7393-1cf2-4d38-a648-631c1f93e345@ewie.name>
 <CAApHDvoLfa2UjGfoGfVL4b=g5VbFgscrLONuC3kKE9=VZeeN=Q@mail.gmail.com>
 <b8d76840-5927-40aa-b38e-8ccb685aea92@app.fastmail.com>
 <aQE29YG5pY4Cl8ym@nathan>
 <aQJ6UIrQeC6impXg@momjian.us>
 <2903384.1761770924@sss.pgh.pa.us>
 <CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aQKGVwVChafkfSub%40momjian.us>
Precedence: bulk

On Thu, Oct 30, 2025 at 10:24:30AM +1300, David Rowley wrote:
> On Thu, 30 Oct 2025 at 09:48, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Bruce Momjian <bruce@momjian.us> writes:
> > > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote:
> > >> I noticed the patch also changes some column types to lowercase:
> > >> ...
> > >> -    category_N TEXT
> > >> +    category_N text
> > >>
> > >> FWIW I tend to use uppercase for those, too, but I'm not sure there is a
> > >> preferred style for the docs.
> >
> > > Agreed, uppercase is better for type names.
> >
> > "text" is not a keyword according to either us or the SQL standard.
> > I agree that there's some reason to capitalize things that are
> > grammar keywords, such as INTEGER or VARCHAR, but it's a big stretch
> > to go from that to capitalizing everything that is a type name.
> > Would you capitalize user-defined type names?
> 
> Going by: git grep -i "\btext\b," we're fairly consistently using
> lower case, so FWIW, when I looked, I thought Eric's change made
> sense.
> 
> How about if Eric just drops the portion of the patch that alters the
> casing of the types and leaves all the keyword uppercasing stuff in.
> Any objections to that part?

Works for me.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.