Date: Fri, 14 Nov 2025 09:09:45 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL-documentation <pgsql-docs@lists.postgresql.org>
Subject: Re: Quoting of *_command arguments
Message-ID: <aRc4Kakf_t3OrZTO@momjian.us>
References: <aROPCQCfvKp9Htk4@momjian.us>
 <97c4fe46-0c52-4fe8-90d3-10da182e587c@eisentraut.org>
 <aRSQN4NxQrvA5PoX@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aRSQN4NxQrvA5PoX@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aRc4Kakf_t3OrZTO%40momjian.us>
Precedence: bulk

On Wed, Nov 12, 2025 at 08:48:39AM -0500, Bruce Momjian wrote:
> On Wed, Nov 12, 2025 at 02:45:16PM +0100, Peter Eisentraut wrote:
> > On 11.11.25 20:31, Bruce Momjian wrote:
> > > We inconsistently double-quote the "%f" and "%p" arguments of
> > > "archive_command" and "restore_command".  Paths with spaces or special
> > > characters, especially directory names in these cases, would need
> > > double-quotes.
> > > 
> > > This patch adds double-quotes to all instances.  I can also go the other
> > > way and remove them all, but we should be consistent.
> > 
> > I think %f doesn't need to be quoted because it will only contain certain
> > characters, but if we tried to clarify that it would probably be too
> > confusing.  It makes sense to nudge people that some quoting is prudent.
> 
> Yeah, I did consider your point but you are right --- it is too complex
> to quote one and not the other and expect people to understand why.
> 
> > Your patch looks good to me.
> 
> Thanks.

Applied, and I added double-quotes for "%r".

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.