pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedBehavior of recovery_target_inclusive.
6+ messages / 4 participants
[nested] [flat]
* Behavior of recovery_target_inclusive.
@ 2017-10-23 13:27 t.katsumata1122@gmail.com
0 siblings, 1 reply; 6+ messages in thread
From: t.katsumata1122@gmail.com @ 2017-10-23 13:27 UTC (permalink / raw)
To: pgsql-docs
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/10/static/index.html
Description:
Hi,
I found a small bug in the PostgreSQL 10 document.
https://www.postgresql.org/docs/10/static/recovery-target-settings.html
At "recovery_target_inclusive (boolean)", nothing is mentioned about
"recovery_target_lsn".
It should be fixed, since "recovery_target_lsn" is affected by the value of
"recovery_target_inclusive".
Could you check this?
Best regards,
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Behavior of recovery_target_inclusive.
@ 2017-10-23 14:05 Michael Paquier <michael.paquier@gmail.com>
parent: t.katsumata1122@gmail.com
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2017-10-23 14:05 UTC (permalink / raw)
To: t.katsumata1122@gmail.com; +Cc: pgsql-docs
On Mon, Oct 23, 2017 at 10:27 PM, <t.katsumata1122@gmail.com> wrote:
> At "recovery_target_inclusive (boolean)", nothing is mentioned about
> "recovery_target_lsn".
> It should be fixed, since "recovery_target_lsn" is affected by the value of
> "recovery_target_inclusive".
>
> Could you check this?
Apologies. You are right, this is a documentation bug and should be
fixed. Attached is a patch to address the problem. The trend on the
documentation page for recovery parameters is to list the options
alphabetically, so recovery_target_lsn comes first.
--
Michael
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Attachments:
recovery-lsn-doc.patch (application/octet-stream, 980B) download
diff --git a/doc/src/sgml/recovery-config.sgml b/doc/src/sgml/recovery-config.sgml
index 4e1aa74c1f..27e261af05 100644
--- a/doc/src/sgml/recovery-config.sgml
+++ b/doc/src/sgml/recovery-config.sgml
@@ -270,8 +270,9 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"' # Windows
Specifies whether to stop just after the specified recovery target
(<literal>true</literal>), or just before the recovery target
(<literal>false</literal>).
- Applies when either <xref linkend="recovery-target-time">
- or <xref linkend="recovery-target-xid"> is specified.
+ Applies when either <xref linkend="recovery-target-lsn">,
+ <xref linkend="recovery-target-time"> or
+ <xref linkend="recovery-target-xid"> is specified.
This setting controls whether transactions
having exactly the target commit time or ID, respectively, will
be included in the recovery. Default is <literal>true</literal>.
* Re: Behavior of recovery_target_inclusive.
@ 2017-10-24 00:43 Tomonari Katsumata <t.katsumata1122@gmail.com>
parent: Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Tomonari Katsumata @ 2017-10-24 00:43 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: pgsql-docs
Hi Michael
Thanks for your reply and quick reaction.
2017-10-23 23:05 GMT+09:00 Michael Paquier <michael.paquier@gmail.com>:
> On Mon, Oct 23, 2017 at 10:27 PM, <t.katsumata1122@gmail.com> wrote:
> > At "recovery_target_inclusive (boolean)", nothing is
> mentioned about
> > "recovery_target_lsn".
> > It should be fixed, since "recovery_target_lsn" is affected
> by the value of
> > "recovery_target_inclusive".
> >
> > Could you check this?
>
> Apologies. You are right, this is a documentation bug and should be
> fixed. Attached is a patch to address the problem. The trend on the
> documentation page for recovery parameters is to list the options
> alphabetically, so recovery_target_lsn comes first.
> --
> Michael
>
Your patch seems good, but I have a question.
Does it need to fix the next sentence?
Like this:
----
This setting controls whether transactions having exactly the target WAL
location (LSN), commit time or ID, respectively, will be included in the
recovery.
----
Best regards,
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Behavior of recovery_target_inclusive.
@ 2017-10-24 00:45 Michael Paquier <michael.paquier@gmail.com>
parent: Tomonari Katsumata <t.katsumata1122@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2017-10-24 00:45 UTC (permalink / raw)
To: Tomonari Katsumata <t.katsumata1122@gmail.com>; +Cc: pgsql-docs
On Tue, Oct 24, 2017 at 9:43 AM, Tomonari Katsumata
<t.katsumata1122@gmail.com> wrote:
> Does it need to fix the next sentence?
Right.
--
Michael
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Behavior of recovery_target_inclusive.
@ 2017-10-24 03:59 Tomonari Katsumata <t.katsumata1122@gmail.com>
parent: Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Tomonari Katsumata @ 2017-10-24 03:59 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: pgsql-docs
Hi,
I rivised the patch.
Please update the file with this patch.
Best regards,
2017-10-24 9:45 GMT+09:00 Michael Paquier <michael.paquier@gmail.com>:
> On Tue, Oct 24, 2017 at 9:43 AM, Tomonari Katsumata
> <t.katsumata1122@gmail.com> wrote:
> > Does it need to fix the next sentence?
>
> Right.
> --
> Michael
>
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Attachments:
recovery-lsn-doc2.patch (application/octet-stream, 1.1K) download
diff --git a/doc/src/sgml/recovery-config.sgml b/doc/src/sgml/recovery-config.sgml
index 4e1aa74c1f..7d0636d44e 100644
--- a/doc/src/sgml/recovery-config.sgml
+++ b/doc/src/sgml/recovery-config.sgml
@@ -270,10 +270,11 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"' # Windows
Specifies whether to stop just after the specified recovery target
(<literal>true</literal>), or just before the recovery target
(<literal>false</literal>).
- Applies when either <xref linkend="recovery-target-time">
- or <xref linkend="recovery-target-xid"> is specified.
+ Applies when either <xref linkend="recovery-target-lsn">,
+ <xref linkend="recovery-target-time"> or
+ <xref linkend="recovery-target-xid"> is specified.
This setting controls whether transactions
- having exactly the target commit time or ID, respectively, will
+ having exactly the target WAL location (LSN), commit time or ID, respectively, will
be included in the recovery. Default is <literal>true</literal>.
</para>
</listitem>
* Re: Behavior of recovery_target_inclusive.
@ 2017-11-04 18:47 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
parent: Tomonari Katsumata <t.katsumata1122@gmail.com>
0 siblings, 0 replies; 6+ messages in thread
From: Peter Eisentraut @ 2017-11-04 18:47 UTC (permalink / raw)
To: Tomonari Katsumata <t.katsumata1122@gmail.com>; Michael Paquier <michael.paquier@gmail.com>; +Cc: pgsql-docs
On 10/23/17 23:59, Tomonari Katsumata wrote:
> I rivised the patch.
> Please update the file with this patch.
committed to master and PG 10
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2017-11-04 18:47 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-10-23 13:27 Behavior of recovery_target_inclusive. t.katsumata1122@gmail.com
2017-10-23 14:05 ` Michael Paquier <michael.paquier@gmail.com>
2017-10-24 00:43 ` Tomonari Katsumata <t.katsumata1122@gmail.com>
2017-10-24 00:45 ` Michael Paquier <michael.paquier@gmail.com>
2017-10-24 03:59 ` Tomonari Katsumata <t.katsumata1122@gmail.com>
2017-11-04 18:47 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox