Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4JpE-0002fS-Nt for pgsql-docs@arkaria.postgresql.org; Wed, 31 May 2023 11:17:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q4JpD-0005qB-Fd for pgsql-docs@arkaria.postgresql.org; Wed, 31 May 2023 11:17:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4JpD-0005q2-6U for pgsql-docs@lists.postgresql.org; Wed, 31 May 2023 11:17:07 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q4Jp7-003Grw-OV for pgsql-docs@lists.postgresql.org; Wed, 31 May 2023 11:17:05 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 811EE580352; Wed, 31 May 2023 07:16:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 31 May 2023 07:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685531819; x=1685539019; bh=4ju1fG77uYmo3 GJ0D/zhxzx3JoF6i5t0RRLB1sPgj4Q=; b=bRG01G+GsJ3DocDXsaqe+imXuH0au qHxld+EgcJTLHggE5DzeJlPPGW12OxjD8Hf4vDLkddLBQB4IIeZEOVNbv1D58i6M Iq81KVldcqMHwC7NR0ESjEfQOi/Gy6DDVhtjXAl8CEYWsF3tU5/dFP7WN/Fu+bir MRmEq4AR7t+ZCKH8EvR1bVP+XOb9ofvIvl2+HO5kvKVZ102hbUlbjyzDPkRj1++n P5d7zxHxhUr032pzNPAqUIRdpyWW3HYUtti3V9ISvcOEnQdxGj7w5dgu0t3MEIIy FFVGV0ObuDxZx7N8N7lMjC0nEgb0j8Guk50ZSxhm3Ifa6dqn7bm5H2Icw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeekledgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepuedtkeehueehtddvgfff heelteefhfeifeduiedtffeitdeludejhfejudefffffnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 31 May 2023 07:16:58 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------90fkhZBi3Te50yKAPs0e6cmR" Message-ID: Date: Wed, 31 May 2023 07:16:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: confusing positioning of notes in connection settings Content-Language: en-US To: Daniel Gustafsson Cc: "Jonathan S. Katz" , Pg Docs References: <6f825d42-a1ce-492a-2ea7-c83e6e65fa8b@postgresql.org> <4e34fcb4-6791-0266-7352-27b769c478f9@enterprisedb.com> <39202431-DF62-42E2-B0C1-500C93AD37C8@yesql.se> From: Peter Eisentraut In-Reply-To: <39202431-DF62-42E2-B0C1-500C93AD37C8@yesql.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------90fkhZBi3Te50yKAPs0e6cmR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26.04.23 07:36, Daniel Gustafsson wrote: >> On 26 Apr 2023, at 10:18, Daniel Gustafsson wrote: >> >>> On 26 Apr 2023, at 08:08, Peter Eisentraut wrote: >> >>> I wonder if the notes are even true. The text for tcp_keepalives_interval already says that it is only supported if TCP_KEEPCNT is supported. > > Re-reading this I think there was some confusion, definitely so on my part. > > tcp_keepalives_interval relies on TCP_KEEPINTVL, with the Windows equivalent > being SIO_KEEPALIVE_VALS. TCP_KEEPCNT is for tcp_keepalives_count which indeed > is not supported on Windows. Jonathans original question was regarding _count > and _timeout and not _interval. > > I do agree that all of these notes may just as well be added to the text, the > option client_connection_check_interval following these have text about > platform compatibility without using a note. How about this patch? The first two hunks are pretty straightforward, they just move the existing text around. For the other two, which are not supported on Windows, I added an explicit parenthetical note. We don't list which of the Unix-like platforms support the respective options, but I suspect that it's all of them in practice? (Otherwise we should be more explicit.) So I think calling out Windows explicitly is sensible, also considering that the first two settings are supported on Windows but the latter two are not. --------------90fkhZBi3Te50yKAPs0e6cmR Content-Type: text/plain; charset=UTF-8; name="0001-doc-Fix-confusing-positioning-of-notes-in-connection.patch" Content-Disposition: attachment; filename*0="0001-doc-Fix-confusing-positioning-of-notes-in-connection.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA5N2ZlNDg5MjYzZjE4MzE0ZTk5ZWM0NzFhYjE2MGRiYzAyNmExODQxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogV2VkLCAzMSBNYXkgMjAyMyAwNzoxMjozOCAtMDQwMApTdWJqZWN0 OiBbUEFUQ0hdIGRvYzogRml4IGNvbmZ1c2luZyBwb3NpdGlvbmluZyBvZiBub3RlcyBpbiBj b25uZWN0aW9uCiBzZXR0aW5ncwoKRGlzY3Vzc2lvbjogaHR0cHM6Ly93d3cucG9zdGdyZXNx bC5vcmcvbWVzc2FnZS1pZC9mbGF0LzZmODI1ZDQyLWExY2UtNDkyYS0yZWE3LWM4M2U2ZTY1 ZmE4YiU0MHBvc3RncmVzcWwub3JnCi0tLQogZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21sIHwg MzAgKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNiBp bnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3Nn bWwvY29uZmlnLnNnbWwgYi9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwKaW5kZXggNWRhNzRi M2M0MC4uNTg3M2EwZWYyZiAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21s CisrKyBiL2RvYy9zcmMvc2dtbC9jb25maWcuc2dtbApAQCAtOTUwLDE4ICs5NTAsMTQgQEAg PHRpdGxlPlRDUCBTZXR0aW5nczwvdGl0bGU+CiAgICAgICAgIHRoZSBvcGVyYXRpbmcgc3lz dGVtIHNob3VsZCBzZW5kIGEgVENQIGtlZXBhbGl2ZSBtZXNzYWdlIHRvIHRoZSBjbGllbnQu CiAgICAgICAgIElmIHRoaXMgdmFsdWUgaXMgc3BlY2lmaWVkIHdpdGhvdXQgdW5pdHMsIGl0 IGlzIHRha2VuIGFzIHNlY29uZHMuCiAgICAgICAgIEEgdmFsdWUgb2YgMCAodGhlIGRlZmF1 bHQpIHNlbGVjdHMgdGhlIG9wZXJhdGluZyBzeXN0ZW0ncyBkZWZhdWx0LgorICAgICAgICBP biBXaW5kb3dzLCBzZXR0aW5nIGEgdmFsdWUgb2YgMCB3aWxsIHNldCB0aGlzIHBhcmFtZXRl ciB0byAyIGhvdXJzLAorICAgICAgICBzaW5jZSBXaW5kb3dzIGRvZXMgbm90IHByb3ZpZGUg YSB3YXkgdG8gcmVhZCB0aGUgc3lzdGVtIGRlZmF1bHQgdmFsdWUuCiAgICAgICAgIFRoaXMg cGFyYW1ldGVyIGlzIHN1cHBvcnRlZCBvbmx5IG9uIHN5c3RlbXMgdGhhdCBzdXBwb3J0CiAg ICAgICAgIDxzeW1ib2w+VENQX0tFRVBJRExFPC9zeW1ib2w+IG9yIGFuIGVxdWl2YWxlbnQg c29ja2V0IG9wdGlvbiwgYW5kIG9uCiAgICAgICAgIFdpbmRvd3M7IG9uIG90aGVyIHN5c3Rl bXMsIGl0IG11c3QgYmUgemVyby4KICAgICAgICAgSW4gc2Vzc2lvbnMgY29ubmVjdGVkIHZp YSBhIFVuaXgtZG9tYWluIHNvY2tldCwgdGhpcyBwYXJhbWV0ZXIgaXMKICAgICAgICAgaWdu b3JlZCBhbmQgYWx3YXlzIHJlYWRzIGFzIHplcm8uCiAgICAgICAgPC9wYXJhPgotICAgICAg IDxub3RlPgotICAgICAgICA8cGFyYT4KLSAgICAgICAgIE9uIFdpbmRvd3MsIHNldHRpbmcg YSB2YWx1ZSBvZiAwIHdpbGwgc2V0IHRoaXMgcGFyYW1ldGVyIHRvIDIgaG91cnMsCi0gICAg ICAgICBzaW5jZSBXaW5kb3dzIGRvZXMgbm90IHByb3ZpZGUgYSB3YXkgdG8gcmVhZCB0aGUg c3lzdGVtIGRlZmF1bHQgdmFsdWUuCi0gICAgICAgIDwvcGFyYT4KLSAgICAgICA8L25vdGU+ CiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8L3Zhcmxpc3RlbnRyeT4KIApAQCAtOTc3LDE4 ICs5NzMsMTQgQEAgPHRpdGxlPlRDUCBTZXR0aW5nczwvdGl0bGU+CiAgICAgICAgIHRoYXQg aGFzIG5vdCBiZWVuIGFja25vd2xlZGdlZCBieSB0aGUgY2xpZW50IHNob3VsZCBiZSByZXRy YW5zbWl0dGVkLgogICAgICAgICBJZiB0aGlzIHZhbHVlIGlzIHNwZWNpZmllZCB3aXRob3V0 IHVuaXRzLCBpdCBpcyB0YWtlbiBhcyBzZWNvbmRzLgogICAgICAgICBBIHZhbHVlIG9mIDAg KHRoZSBkZWZhdWx0KSBzZWxlY3RzIHRoZSBvcGVyYXRpbmcgc3lzdGVtJ3MgZGVmYXVsdC4K KyAgICAgICAgT24gV2luZG93cywgc2V0dGluZyBhIHZhbHVlIG9mIDAgd2lsbCBzZXQgdGhp cyBwYXJhbWV0ZXIgdG8gMSBzZWNvbmQsCisgICAgICAgIHNpbmNlIFdpbmRvd3MgZG9lcyBu b3QgcHJvdmlkZSBhIHdheSB0byByZWFkIHRoZSBzeXN0ZW0gZGVmYXVsdCB2YWx1ZS4KICAg ICAgICAgVGhpcyBwYXJhbWV0ZXIgaXMgc3VwcG9ydGVkIG9ubHkgb24gc3lzdGVtcyB0aGF0 IHN1cHBvcnQKICAgICAgICAgPHN5bWJvbD5UQ1BfS0VFUElOVFZMPC9zeW1ib2w+IG9yIGFu IGVxdWl2YWxlbnQgc29ja2V0IG9wdGlvbiwgYW5kIG9uCiAgICAgICAgIFdpbmRvd3M7IG9u IG90aGVyIHN5c3RlbXMsIGl0IG11c3QgYmUgemVyby4KICAgICAgICAgSW4gc2Vzc2lvbnMg Y29ubmVjdGVkIHZpYSBhIFVuaXgtZG9tYWluIHNvY2tldCwgdGhpcyBwYXJhbWV0ZXIgaXMK ICAgICAgICAgaWdub3JlZCBhbmQgYWx3YXlzIHJlYWRzIGFzIHplcm8uCiAgICAgICAgPC9w YXJhPgotICAgICAgIDxub3RlPgotICAgICAgICA8cGFyYT4KLSAgICAgICAgIE9uIFdpbmRv d3MsIHNldHRpbmcgYSB2YWx1ZSBvZiAwIHdpbGwgc2V0IHRoaXMgcGFyYW1ldGVyIHRvIDEg c2Vjb25kLAotICAgICAgICAgc2luY2UgV2luZG93cyBkb2VzIG5vdCBwcm92aWRlIGEgd2F5 IHRvIHJlYWQgdGhlIHN5c3RlbSBkZWZhdWx0IHZhbHVlLgotICAgICAgICA8L3BhcmE+Ci0g ICAgICAgPC9ub3RlPgogICAgICAgPC9saXN0aXRlbT4KICAgICAgPC92YXJsaXN0ZW50cnk+ CiAKQEAgLTEwMDQsMTYgKzk5NiwxMSBAQCA8dGl0bGU+VENQIFNldHRpbmdzPC90aXRsZT4K ICAgICAgICAgdGhlIHNlcnZlcidzIGNvbm5lY3Rpb24gdG8gdGhlIGNsaWVudCBpcyBjb25z aWRlcmVkIGRlYWQuCiAgICAgICAgIEEgdmFsdWUgb2YgMCAodGhlIGRlZmF1bHQpIHNlbGVj dHMgdGhlIG9wZXJhdGluZyBzeXN0ZW0ncyBkZWZhdWx0LgogICAgICAgICBUaGlzIHBhcmFt ZXRlciBpcyBzdXBwb3J0ZWQgb25seSBvbiBzeXN0ZW1zIHRoYXQgc3VwcG9ydAotICAgICAg ICA8c3ltYm9sPlRDUF9LRUVQQ05UPC9zeW1ib2w+IG9yIGFuIGVxdWl2YWxlbnQgc29ja2V0 IG9wdGlvbjsKKyAgICAgICAgPHN5bWJvbD5UQ1BfS0VFUENOVDwvc3ltYm9sPiBvciBhbiBl cXVpdmFsZW50IHNvY2tldCBvcHRpb24gKHdoaWNoIGRvZXMgbm90IGluY2x1ZGUgV2luZG93 cyk7CiAgICAgICAgIG9uIG90aGVyIHN5c3RlbXMsIGl0IG11c3QgYmUgemVyby4KICAgICAg ICAgSW4gc2Vzc2lvbnMgY29ubmVjdGVkIHZpYSBhIFVuaXgtZG9tYWluIHNvY2tldCwgdGhp cyBwYXJhbWV0ZXIgaXMKICAgICAgICAgaWdub3JlZCBhbmQgYWx3YXlzIHJlYWRzIGFzIHpl cm8uCiAgICAgICAgPC9wYXJhPgotICAgICAgIDxub3RlPgotICAgICAgICA8cGFyYT4KLSAg ICAgICAgIFRoaXMgcGFyYW1ldGVyIGlzIG5vdCBzdXBwb3J0ZWQgb24gV2luZG93cywgYW5k IG11c3QgYmUgemVyby4KLSAgICAgICAgPC9wYXJhPgotICAgICAgIDwvbm90ZT4KICAgICAg IDwvbGlzdGl0ZW0+CiAgICAgIDwvdmFybGlzdGVudHJ5PgogCkBAIC0xMDMwLDE1ICsxMDE3 LDEwIEBAIDx0aXRsZT5UQ1AgU2V0dGluZ3M8L3RpdGxlPgogICAgICAgICBJZiB0aGlzIHZh bHVlIGlzIHNwZWNpZmllZCB3aXRob3V0IHVuaXRzLCBpdCBpcyB0YWtlbiBhcyBtaWxsaXNl Y29uZHMuCiAgICAgICAgIEEgdmFsdWUgb2YgMCAodGhlIGRlZmF1bHQpIHNlbGVjdHMgdGhl IG9wZXJhdGluZyBzeXN0ZW0ncyBkZWZhdWx0LgogICAgICAgICBUaGlzIHBhcmFtZXRlciBp cyBzdXBwb3J0ZWQgb25seSBvbiBzeXN0ZW1zIHRoYXQgc3VwcG9ydAotICAgICAgICA8c3lt Ym9sPlRDUF9VU0VSX1RJTUVPVVQ8L3N5bWJvbD47IG9uIG90aGVyIHN5c3RlbXMsIGl0IG11 c3QgYmUgemVyby4KKyAgICAgICAgPHN5bWJvbD5UQ1BfVVNFUl9USU1FT1VUPC9zeW1ib2w+ ICh3aGljaCBkb2VzIG5vdCBpbmNsdWRlIFdpbmRvd3MpOyBvbiBvdGhlciBzeXN0ZW1zLCBp dCBtdXN0IGJlIHplcm8uCiAgICAgICAgIEluIHNlc3Npb25zIGNvbm5lY3RlZCB2aWEgYSBV bml4LWRvbWFpbiBzb2NrZXQsIHRoaXMgcGFyYW1ldGVyIGlzCiAgICAgICAgIGlnbm9yZWQg YW5kIGFsd2F5cyByZWFkcyBhcyB6ZXJvLgogICAgICAgIDwvcGFyYT4KLSAgICAgICA8bm90 ZT4KLSAgICAgICAgPHBhcmE+Ci0gICAgICAgICBUaGlzIHBhcmFtZXRlciBpcyBub3Qgc3Vw cG9ydGVkIG9uIFdpbmRvd3MsIGFuZCBtdXN0IGJlIHplcm8uCi0gICAgICAgIDwvcGFyYT4K LSAgICAgICA8L25vdGU+CiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8L3Zhcmxpc3RlbnRy eT4KIAotLSAKMi40MC4xCgo= --------------90fkhZBi3Te50yKAPs0e6cmR--