public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: Nikolay Samokhvalov <[email protected]>
Cc: Laurenz Albe <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Doc: clarify that pg_upgrade statistics transfer works cross-version
Date: Tue, 24 Mar 2026 11:04:38 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAM527d89GmcMV5GD2PXS-a3ay3YE-HVSwV4NT0_o2ySf_5v8Kw@mail.gmail.com>
References: <CAM527d_Qt9ZGt99vgTaidfObRiDH0R5F_uEfum9zHeZbc+LwCQ@mail.gmail.com>
	<[email protected]>
	<CAM527d89GmcMV5GD2PXS-a3ay3YE-HVSwV4NT0_o2ySf_5v8Kw@mail.gmail.com>

On Tue, Mar 24, 2026 at 05:36:42AM -0700, Nikolay Samokhvalov wrote:
> On Mon, Mar 23, 2026 at 23:59 Laurenz Albe <[email protected]> wrote:
> ...
> 
>     I think that your patch offers too much detail,
>     like from which relations the statistics are extracted.  Anybody
>     who wants to know that level of detail probably has to read the
>     source code anyway.
> 
>     How about adding a simple remark, like
> 
>     --- a/doc/src/sgml/ref/pgupgrade.sgml
>     +++ b/doc/src/sgml/ref/pgupgrade.sgml
>     @@ -837,6 +837,8 @@ psql --username=postgres --file=script.sql postgres
>           all statistics, such as those created explicitly with
>           <xref linkend="sql-createstatistics"/>, custom statistics added by
>           an extension, or statistics collected by the cumulative statistics
>     system.
>     +     Transferring optimizer statistics works regardless of the old
>     cluster's
>     +     major version.
>          </para>
> 
>          <para>
> 
> 
> That would work too -- my goal was just to resolve confusion.

I was under the same impression --- that it only worked with upgrades
_from_ PG 18 and later.  However, I can't find any documentation on this
limitation, so why did so many think this was true?  I don't think
adding anything to the docs is the right approach.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.





view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Doc: clarify that pg_upgrade statistics transfer works cross-version
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox