Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnoPU-0001uJ-5d for pgsql-docs@arkaria.postgresql.org; Wed, 17 Jul 2019 18:12:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hnoPS-0002zl-H9 for pgsql-docs@arkaria.postgresql.org; Wed, 17 Jul 2019 18:12:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnoPS-0002xO-5M for pgsql-docs@lists.postgresql.org; Wed, 17 Jul 2019 18:12:10 +0000 Received: from courriel.mines-paristech.fr ([77.158.173.149] helo=antispam-1.ensmp.fr) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1hnoPP-0007Wt-6J for pgsql-docs@lists.postgresql.org; Wed, 17 Jul 2019 18:12:08 +0000 Received: from smtp-5.mines-paristech.fr (smtp.mines-paristech.fr [77.158.173.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by antispam-1.ensmp.fr (antispam.mines-paristech.fr) with ESMTPS id 6F87755DF1; Wed, 17 Jul 2019 20:12:04 +0200 (CEST) Received: from lancre (157-157-240-203.dsl.dynamic.simnet.is [157.157.240.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp-5.mines-paristech.fr (Postfix) with ESMTPSA id E6FFC20251; Wed, 17 Jul 2019 20:12:03 +0200 (CEST) Date: Wed, 17 Jul 2019 18:12:02 +0000 (GMT) From: Fabien COELHO X-X-Sender: fabien@lancre To: Daniel Gustafsson cc: Tom Lane , pgsql-docs@lists.postgresql.org, Michael Paquier Subject: Re: SPITupleTable members missing in docs In-Reply-To: Message-ID: References: <0D19F836-B743-4340-B6A2-F148CA3DD1F0@yesql.se> <4584.1562943879@sss.pgh.pa.us> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-418030854-1563387124=:6887" X-CLAMAV-SCAN: ok X-VRSPAM-SCORE: -100 X-VRSPAM-STATE: legit X-VRSPAM-CAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrieefgddutddtucetufdoteggodetrfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvufgjkfhffgggtgesmhdtreertderjeenucfhrhhomhephfgrsghivghnucevqffgnffjqfcuoegtohgvlhhhohestghrihdrvghnshhmphdrfhhrqeenucfkphepudehjedrudehjedrvdegtddrvddtfeenucfrrghrrghmpehmohguvgepshhmthhpohhuth X-VRSPAM-EXTCAUSE: mhhouggvpehsmhhtphhouhht List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-418030854-1563387124=:6887 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT >>> I quite like this suggestion, so I’ve changed the patch to do this. Removed >>> the doc: in the commit message to indicate that this is no longer just touching >>> documentation. >> >> About v2: applies cleanly, compiles, make check and doc gen ok. >> >> However, the documentation does not look right, field comments are not >> aligned. Do not use tabs in the sgml file, use spaces only, otherwise >> the display layout is left to chance. > > Of course, that was me fat-fingering. Fixed in the attached v3. > Thanks for reviewing! V3 fixes the html display alignment issue. Patch marked as ready. -- Fabien. --8323329-418030854-1563387124=:6887--