pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Doc: Fix description of %L escape in PostgreSQL 18 release notes
4+ messages / 3 participants
[nested] [flat]

* Doc: Fix description of %L escape in PostgreSQL 18 release notes
@ 2026-08-14 06:13 Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>
  2026-08-17 18:04 ` Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes Greg Sabino Mullane <htamfids@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Keisuke Kuroda @ 2026-08-14 06:13 UTC (permalink / raw)
  To: pgsql-docs@lists.postgresql.org

Hi hackers,

I noticed a small mistake in the PostgreSQL 18 release notes
(release-18.sgml) regarding the new %L escape for log_line_prefix.

Currently, the release note says that %L outputs the "client" IP address:

---
Add <xref linkend="guc-log-line-prefix"/> escape
<literal>%L</literal> to output the client <acronym>IP</acronym>
address (Greg Sabino Mullane)
---

However, %L actually outputs the local IP address of the server. The
documentation for log_line_prefix describes %L as:

> "Local address (the IP address on the server that the client connected to)"

Attached is a patch to correct this in the release notes:

---
Add <xref linkend="guc-log-line-prefix"/> escape
<literal>%L</literal> to output the local <acronym>IP</acronym>
address on the server that the client connected to (Greg Sabino Mullane)
---

Best Regards,
Keisuke Kuroda

Attachments:

  [application/octet-stream] fix_release_note_L_escape.patch (683B, ../../CANDwggK8AZJx+tGKY+h_8a90rqZ_+4dvGOFvDuRVVSjQvAafbg@mail.gmail.com/2-fix_release_note_L_escape.patch)
  download | inline diff:
diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
index 7a455bf9c64..90cc9589bbb 100644
--- a/doc/src/sgml/release-18.sgml
+++ b/doc/src/sgml/release-18.sgml
@@ -9680,8 +9680,8 @@ Author: Tom Lane <tgl@sss.pgh.pa.us>
       <listitem>
       <para>
       Add <xref linkend="guc-log-line-prefix"/> escape
-      <literal>%L</literal> to output the client <acronym>IP</acronym>
-      address (Greg Sabino Mullane)
+      <literal>%L</literal> to output the local <acronym>IP</acronym>
+      address on the server that the client connected to (Greg Sabino Mullane)
       <ulink url="&commit_baseurl;3516ea768">&sect;</ulink>
       </para>
       </listitem>


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes
  2026-08-14 06:13 Doc: Fix description of %L escape in PostgreSQL 18 release notes Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>
@ 2026-08-17 18:04 ` Greg Sabino Mullane <htamfids@gmail.com>
  2026-08-18 06:08   ` Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 4+ messages in thread

From: Greg Sabino Mullane @ 2026-08-17 18:04 UTC (permalink / raw)
  To: Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org

Looks good, thanks for spotting that!

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes
  2026-08-14 06:13 Doc: Fix description of %L escape in PostgreSQL 18 release notes Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>
  2026-08-17 18:04 ` Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes Greg Sabino Mullane <htamfids@gmail.com>
@ 2026-08-18 06:08   ` Michael Paquier <michael@paquier.xyz>
  2026-08-19 04:49     ` Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Michael Paquier @ 2026-08-18 06:08 UTC (permalink / raw)
  To: Greg Sabino Mullane <htamfids@gmail.com>; +Cc: Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>; pgsql-docs@lists.postgresql.org

On Mon, Aug 17, 2026 at 02:04:05PM -0400, Greg Sabino Mullane wrote:
> Looks good, thanks for spotting that!

Sounds right to me.  Will fix.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../../aoP2-P8W-V0EmGl4@paquier.xyz/2-signature.asc)
  download

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes
  2026-08-14 06:13 Doc: Fix description of %L escape in PostgreSQL 18 release notes Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>
  2026-08-17 18:04 ` Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes Greg Sabino Mullane <htamfids@gmail.com>
  2026-08-18 06:08   ` Re: Doc: Fix description of %L escape in PostgreSQL 18 release notes Michael Paquier <michael@paquier.xyz>
@ 2026-08-19 04:49     ` Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>
  0 siblings, 0 replies; 4+ messages in thread

From: Keisuke Kuroda @ 2026-08-19 04:49 UTC (permalink / raw)
  To: Michael Paquier <michael@paquier.xyz>; +Cc: Greg Sabino Mullane <htamfids@gmail.com>; pgsql-docs@lists.postgresql.org

Thanks for reviewing and committing!






^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2026-08-19 04:49 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-08-14 06:13 Doc: Fix description of %L escape in PostgreSQL 18 release notes Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>
2026-08-17 18:04 ` Greg Sabino Mullane <htamfids@gmail.com>
2026-08-18 06:08   ` Michael Paquier <michael@paquier.xyz>
2026-08-19 04:49     ` Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox