Content-Type: multipart/mixed; boundary="------------UN0G5UBUlCIDa1FRqpvAKeO3"
Message-ID: <b1cfd248-6860-4a95-bb62-07009f5e486e@oss.nttdata.com>
Date: Tue, 15 Jul 2025 01:51:30 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Clarify VACUUM FULL exclusion in total_vacuum_time docs
Content-Language: en-US
To: Robert Treat <rob@xzilla.net>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>
References: <2ac375d1-591b-4f1b-a2af-f24335567866@oss.nttdata.com>
 <CAKFQuwYgErraNuAUme-6dSwmwNSSStC8SL7560Qy2sAtUG5J+Q@mail.gmail.com>
 <CABV9wwMs4g9nq-fKy=fFqU-rQUf6fiCqJg4_+MkqOnJE1n2TBA@mail.gmail.com>
 <f58eb77f-0d8f-4f58-bed2-a100bd7e0814@oss.nttdata.com>
 <CAJSLCQ3YPKaB7tQDyg8BbVuo80EGn_j6kycNGG3oZB59P8tgrg@mail.gmail.com>
 <bb97b8d4-2f44-4b95-9b82-a54ecbce9e76@oss.nttdata.com>
 <CAJSLCQ27T5utjOipbaqArGCPS1VT+2Uqx_g2NH3od_spHxkoig@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <CAJSLCQ27T5utjOipbaqArGCPS1VT+2Uqx_g2NH3od_spHxkoig@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/b1cfd248-6860-4a95-bb62-07009f5e486e%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------UN0G5UBUlCIDa1FRqpvAKeO3
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2025/06/18 6:53, Robert Treat wrote:
> I think the more cases where you document this behavior (and I do like
> the idea of documenting it for total_vacuum_time), the more one is
> likely to think that places where it is not documented operate
> differently. To that end, I think documenting it for
> n_ins_since_vacuum as well is a good idea, but I don't feel strongly
> that it needs to be backpatched; the old documentation wasn't wrong
> per se, rather this is a documentation improvement as a result of new
> development.

Agreed. The attached patch updates the docs to clarify that both
total_vacuum_time and n_ins_since_vacuum exclude VACUUM FULL.

Unless there are any objections, I'll commit this to master and
back-patch it to v18 only.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

--------------UN0G5UBUlCIDa1FRqpvAKeO3
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-doc-Clarify-that-total_vacuum_time-excludes-VACUU.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-doc-Clarify-that-total_vacuum_time-excludes-VACUU.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBiMWU2NGVlNjI5MTViODgzMzY5YTQ2ZTZhZGQ0MTdhY2RlMTVkYTg4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFR1ZSwgMTUgSnVsIDIwMjUgMDE6MjE6MjQgKzA5MDAKU3ViamVjdDogW1BB
VENIIHYxXSBkb2M6IENsYXJpZnkgdGhhdCB0b3RhbF92YWN1dW1fdGltZSBleGNsdWRlcyBW
QUNVVU0gRlVMTC4KClRoZSBsYXN0X3ZhY3V1bSBhbmQgdmFjdXVtX2NvdW50IGZpZWxkcyBp
biBwZ19zdGF0X2FsbF90YWJsZXMgYWxyZWFkeQpzdGF0ZSB0aGF0IHRoZXkgZG8gbm90IGlu
Y2x1ZGUgVkFDVVVNIEZVTEwuIEhvd2V2ZXIsIHRvdGFsX3ZhY3V1bV90aW1lLAp3aGljaCBh
bHNvIGV4Y2x1ZGVzIFZBQ1VVTSBGVUxMLCBkaWQgbm90IG1lbnRpb24gdGhpcy4gVGhpcyBj
b3VsZAptaXNsZWFkIHVzZXJzIGludG8gdGhpbmtpbmcgVkFDVVVNIEZVTEwgdGltZSBpcyBp
bmNsdWRlZC4KClRvIGFkZHJlc3MgdGhpcywgdGhpcyBjb21taXQgdXBkYXRlcyB0aGUgZG9j
dW1lbnRhdGlvbiBmb3IKcGdfc3RhdF9hbGxfdGFibGVzIHRvIGV4cGxpY2l0bHkgc3RhdGUg
dGhhdCB0b3RhbF92YWN1dW1fdGltZSBkb2VzIG5vdApjb3VudCBWQUNVVU0gRlVMTC4KCkJh
Y2stcGF0Y2hlZCB0byB2MTgsIHdoZXJlIHRvdGFsX3ZhY3V1bV90aW1lIHdhcyBpbnRyb2R1
Y2VkLgoKQWRkaXRpb25hbGx5LCB0aGlzIGNvbW1pdCBjbGFyaWZpZXMgdGhhdCBuX2luc19z
aW5jZV92YWN1dW0gYWxzbwpleGNsdWRlcyBWQUNVVU0gRlVMTC4gQWx0aG91Z2ggbl9pbnNf
c2luY2VfdmFjdXVtIHdhcyBhZGRlZCBpbiB2MTMsCndlIGFyZSBub3QgYmFjay1wYXRjaGlu
ZyB0aGlzIGNoYW5nZSB0byBzdGFibGUgYnJhbmNoZXMsIGFzIGl0IGlzCmEgZG9jdW1lbnRh
dGlvbiBpbXByb3ZlbWVudCwgbm90IGEgYnVnIGZpeC4KCkF1dGhvcjogRnVqaWkgTWFzYW8g
PG1hc2FvLmZ1amlpQGdtYWlsLmNvbT4KUmV2aWV3ZWQtYnk6IERhdmlkIEcuIEpvaG5zdG9u
IDxkYXZpZC5nLmpvaG5zdG9uQGdtYWlsLmNvbT4KUmV2aWV3ZWQtYnk6IFJvYmVydCBUcmVh
dCA8cm9iQHh6aWxsYS5uZXQ+CkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vMmFj
Mzc1ZDEtNTkxYi00ZjFiLWEyYWYtZjI0MzM1NTY3ODY2QG9zcy5udHRkYXRhLmNvbQpCYWNr
cGF0Y2gtdGhyb3VnaDogMTgKLS0tCiBkb2Mvc3JjL3NnbWwvbW9uaXRvcmluZy5zZ21sIHwg
NCArKystCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p
CgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dtbCBiL2RvYy9zcmMv
c2dtbC9tb25pdG9yaW5nLnNnbWwKaW5kZXggNDI2NWEyMmQ0ZGUuLjgyM2FmZTFiMzBiIDEw
MDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvbW9uaXRvcmluZy5zZ21sCisrKyBiL2RvYy9zcmMv
c2dtbC9tb25pdG9yaW5nLnNnbWwKQEAgLTM5ODAsNiArMzk4MCw3IEBAIGRlc2NyaXB0aW9u
IHwgV2FpdGluZyBmb3IgYSBuZXdseSBpbml0aWFsaXplZCBXQUwgZmlsZSB0byByZWFjaCBk
dXJhYmxlIHN0b3JhZ2UKICAgICAgIDwvcGFyYT4KICAgICAgIDxwYXJhPgogICAgICAgIEVz
dGltYXRlZCBudW1iZXIgb2Ygcm93cyBpbnNlcnRlZCBzaW5jZSB0aGlzIHRhYmxlIHdhcyBs
YXN0IHZhY3V1bWVkCisgICAgICAgKG5vdCBjb3VudGluZyA8Y29tbWFuZD5WQUNVVU0gRlVM
TDwvY29tbWFuZD4pCiAgICAgICA8L3BhcmE+PC9lbnRyeT4KICAgICAgPC9yb3c+CiAKQEAg
LTQwNjYsNyArNDA2Nyw4IEBAIGRlc2NyaXB0aW9uIHwgV2FpdGluZyBmb3IgYSBuZXdseSBp
bml0aWFsaXplZCBXQUwgZmlsZSB0byByZWFjaCBkdXJhYmxlIHN0b3JhZ2UKICAgICAgICA8
c3RydWN0ZmllbGQ+dG90YWxfdmFjdXVtX3RpbWU8L3N0cnVjdGZpZWxkPiA8dHlwZT5kb3Vi
bGUgcHJlY2lzaW9uPC90eXBlPgogICAgICAgPC9wYXJhPgogICAgICAgPHBhcmE+Ci0gICAg
ICAgVG90YWwgdGltZSB0aGlzIHRhYmxlIGhhcyBiZWVuIG1hbnVhbGx5IHZhY3V1bWVkLCBp
biBtaWxsaXNlY29uZHMuCisgICAgICAgVG90YWwgdGltZSB0aGlzIHRhYmxlIGhhcyBiZWVu
IG1hbnVhbGx5IHZhY3V1bWVkLCBpbiBtaWxsaXNlY29uZHMKKyAgICAgICAobm90IGNvdW50
aW5nIDxjb21tYW5kPlZBQ1VVTSBGVUxMPC9jb21tYW5kPikuCiAgICAgICAgKFRoaXMgaW5j
bHVkZXMgdGhlIHRpbWUgc3BlbnQgc2xlZXBpbmcgZHVlIHRvIGNvc3QtYmFzZWQgZGVsYXlz
LikKICAgICAgIDwvcGFyYT48L2VudHJ5PgogICAgICA8L3Jvdz4KLS0gCjIuNDkuMAoK

--------------UN0G5UBUlCIDa1FRqpvAKeO3--