Subject: Re: Roles for pg_basebackup
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-docs@lists.postgresql.org
References: <ECEBD212-7101-41EB-84F3-2F356E4B6401@yesql.se>
 <20200428043755.GC279958@paquier.xyz>
 <b11cc8df-c4c3-5b19-995e-2a9853720bea@oss.nttdata.com>
 <BEDCD8D3-D360-45AD-A452-C77C287B7DBF@yesql.se>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <b460f2fc-36f4-b5e9-fea1-49f2e26b31a7@oss.nttdata.com>
Date: Fri, 1 May 2020 12:29:09 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <BEDCD8D3-D360-45AD-A452-C77C287B7DBF@yesql.se>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/04/28 17:15, Daniel Gustafsson wrote:
>> On 28 Apr 2020, at 07:22, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> On 2020/04/28 13:37, Michael Paquier wrote:
>>> On Mon, Apr 27, 2020 at 12:16:41PM +0200, Daniel Gustafsson wrote:
>>>> Based on a recent conversation about backups I had I propose a small tweak to
>>>> the pg_basebackup documentation.  Listing the user types in the reverse order
>>>> from today, putting superuser last, makes it IMO a little clearer that a
>>>> REPLICATION role is preferrable to using a superuser for running backups.
>>> Makes sense to me.  We do that in logical-replication.sgml as well as
>>> pg_rewind.sgml (the latter outlines superuser rights last).
>>
>> Seems there are other documentations having the similar description,
>> for example, pg_receivewal.sgml, func.sgml and high-availability.sgml.
>> Isn't it better to update also them at the same time?
> 
> That doe make sense.  I've updated the places where I think a user configuring
> the system might conceivably infer a preference from the order, but have left
> the other ones as is.

Thanks for updating the patch! It looks good to me.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION