Message-ID: <b56ce3bf-d308-8dcf-7eaf-e1d3acd021a1@enterprisedb.com>
Date: Mon, 7 Feb 2022 17:12:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: maximum number of backtrace frames logged by backtrace_functions
Content-Language: en-US
To: Fujii Masao <masao.fujii@oss.nttdata.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-docs@lists.postgresql.org
References: <0f0ed9f3-3892-e8a3-51c9-ed268dff6bdd@oss.nttdata.com>
 <4e16a3e9-e717-05e1-d905-6c21beba80f8@enterprisedb.com>
 <b22cd3c0-d76b-0379-5971-8637b65b8e87@oss.nttdata.com>
 <b219d7c9-fb66-c762-ce90-ef20c0667a02@enterprisedb.com>
 <252159.1643899696@sss.pgh.pa.us>
 <e312116f-9c44-b7f6-3cfc-4c67f50bbbc7@oss.nttdata.com>
 <33675df8-60e1-7da6-8995-3743668fd682@oss.nttdata.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <33675df8-60e1-7da6-8995-3743668fd682@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/b56ce3bf-d308-8dcf-7eaf-e1d3acd021a1%40enterprisedb.com>
Precedence: bulk

On 07.02.22 06:29, Fujii Masao wrote:
>>
>> On 2022/02/03 23:48, Tom Lane wrote:
>>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>>>> How about we issue a message when the backtrace is cut off.  Then it's
>>>> immediately visible to the user, instead of hidden away somewhere in 
>>>> the
>>>> documentation.  Something like this (untested):
>>>
>>> +1 for idea (I didn't test it either).
>>
>> +1. I made this change to the patch and confirmed that it worked fine.
> 
> Barring any objection, I will commit the patch.

This change looks good to me.  There is also backtrace code in assert.c 
that might want the same treatment.