Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Fri, 24 Oct 2025 10:40:18 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "David Rowley" <dgrowleyml@gmail.com>, "Erik Wienhold" <ewie@ewie.name>
Cc: pgsql-docs@lists.postgresql.org
Message-Id: <b8d76840-5927-40aa-b38e-8ccb685aea92@app.fastmail.com>
In-Reply-To: 
 <CAApHDvoLfa2UjGfoGfVL4b=g5VbFgscrLONuC3kKE9=VZeeN=Q@mail.gmail.com>
References: <82eb512b-8ed2-46be-b311-54ffd26978c4@ewie.name>
 <a5034028-3f97-4157-8fd2-6eb552ffaab8@app.fastmail.com>
 <0a9d7393-1cf2-4d38-a648-631c1f93e345@ewie.name>
 <CAApHDvoLfa2UjGfoGfVL4b=g5VbFgscrLONuC3kKE9=VZeeN=Q@mail.gmail.com>
Subject: Re: Use uppercase keywords in foreign key tutorial
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b8d76840-5927-40aa-b38e-8ccb685aea92%40app.fastmail.com>
Precedence: bulk

On Thu, Oct 23, 2025, at 7:50 PM, David Rowley wrote:
> I'm not so sure about the "Should be pushed to all stable branches"
> part as it seems more of a general improvement than fixing a mistake.
> I imagine there will be varying opinions on that, however.
>

I also classify this as an improvement. No need to backpatch. I would apply
changes to back branches if the query is wrong; that's not the case.

I checked v2 and it looks good to me.

Since you are changing the query format, we have a mix of

CREATE TABLE foo(a int);
CREATE TABLE foo (a int);

The latter reads better for me. The same logic applies to VALUES. There is a
mix of space or non-space before parenthesis. Consistency is a good goal.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/