Subject: Re: misc doc fixes for REL_12_STABLE
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@lists.postgresql.org
References: <a068f947-7a51-5df1-b3fd-1a131ae5c044@postgrespro.ru>
 <20190712044418.GG2149@paquier.xyz>
From: Liudmila Mantrova <l.mantrova@postgrespro.ru>
Message-ID: <bab8c777-426e-f627-1bc5-e1c2d7edc548@postgrespro.ru>
Date: Fri, 12 Jul 2019 12:35:49 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20190712044418.GG2149@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 7/12/19 7:44 AM, Michael Paquier wrote:
> On Thu, Jul 11, 2019 at 05:49:26PM +0300, Liudmila Mantrova wrote:
>> Please consider a patch that fixes some trivial issues in new doc fragments
>> (a couple of typos/ambiguities and some tags that affect translation).
> Thanks for the patch.  I have one comment.
>
>> -     backups.  Moreover, because it writes a backup_label file on the
>> -     master, it can cause the master to fail to restart automatically after
>> -     a crash.  On the other hand, the erroneous removal of a backup_label
>> -     file from a backup or standby is a common mistake which can result
>> +     backups.  Moreover, because it creates a backup label file, as
>> +     described below, it can block automatic restart of the master server
>> +     after a crash. On the other hand, the erroneous removal of this
>> +     file from a backup or standby is a common mistake, which can result
>>        in serious data corruption.  If it is necessary to use this method,
>>        the following steps may be used.
> Okay, yes that could be a bit confusing for the reader.  Nit: I would
> replace "master" with "primary" while we are in the area.  What do you
> think?
>
> But that's the only comment I have, the rest looks good!
> --
> Michael

Hi Michael,

Changing master to primary was my first inclination, but I saw that we 
have 8 masters and 4 primaries here. So maybe we should have another 
consistency patch (that probably goes beyond this chapter). I can 
prepare one if you like.

P.S. I'm not particularly happy about this paragraph either, but that's 
as far as I could get without twisting the original ideas.


-- 
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company