Message-ID: <c1b3ed843b5002d56c04885b7ce7d0eea08c22c9.camel@cybertec.at>
Subject: Re: Role membership and DROP
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, pgsql-docs@lists.postgresql.org
Date: Fri, 15 Nov 2019 10:32:11 +0100
In-Reply-To: <6808.1573683426@sss.pgh.pa.us>
References: <504497aca66bf34bdcdd90bd0bcebdc3a33f577b.camel@cybertec.at>
	 <6808.1573683426@sss.pgh.pa.us>
Content-Type: multipart/mixed; boundary="=-LNN3UlfuEURHgHPgxO7Q"
User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) 
MIME-Version: 1.0
Precedence: bulk


--=-LNN3UlfuEURHgHPgxO7Q
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Wed, 2019-11-13 at 17:17 -0500, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > I realized only today that if role A is a member of role B,
> > A can ALTER and DROP objects owned by B.
> > I don't have a problem with that, but the documentation seems to
> > suggest otherwise.  For example, for DROP TABLE:
> >     Only the table owner, the schema owner, and superuser can drop a table.
> 
> Generally, if you are a member of a role, that means you are the role for
> privilege-test purposes.  I'm not on board with adding "(or a member of
> that role)" to every place it could conceivably be added; I think that
> would be more annoying than helpful.
> 
> It might be worth clarifying this point in section 5.7,
> 
> https://www.postgresql.org/docs/devel/ddl-priv.html
> 
> but let's not duplicate that in every ref/ page.

That's much better.

I have attached a proposed patch.

Yours,
Laurenz Albe

--=-LNN3UlfuEURHgHPgxO7Q
Content-Disposition: attachment;
	filename*0=0001-Document-that-the-right-to-ALTER-or-DROP-can-be-inhe.pat;
	filename*1=ch
Content-Type: text/x-patch;
	name="0001-Document-that-the-right-to-ALTER-or-DROP-can-be-inhe.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSBiYWRmZTU5NzUwZGVjODJkZmZlMThhNWE0M2ZiMTZmNzJmMjgzYTdkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogRnJpLCAxNSBOb3YgMjAxOSAxMDoyODoyNiArMDEwMApTdWJqZWN0OiBbUEFUQ0hd
IERvY3VtZW50IHRoYXQgdGhlIHJpZ2h0IHRvIEFMVEVSIG9yIERST1AgY2FuIGJlIGluaGVyaXRl
ZAoKRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS81MDQ0OTdhY2E2NmJmMzRiZGNkZDkw
YmQwYmNlYmRjM2EzM2Y1NzdiLmNhbWVsQGN5YmVydGVjLmF0Ci0tLQogZG9jL3NyYy9zZ21sL2Rk
bC5zZ21sIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRp
b24oLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvZGRsLnNnbWwgYi9kb2Mvc3JjL3NnbWwv
ZGRsLnNnbWwKaW5kZXggZDcxNThjMWIwMy4uNTFlMTk1N2Y4NSAxMDA2NDQKLS0tIGEvZG9jL3Ny
Yy9zZ21sL2RkbC5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9kZGwuc2dtbApAQCAtMTU3OSw3ICsx
NTc5LDggQEAgQUxURVIgVEFCTEUgcHJvZHVjdHMgUkVOQU1FIFRPIGl0ZW1zOwogCiAgIDxwYXJh
PgogICAgVGhlIHJpZ2h0IHRvIG1vZGlmeSBvciBkZXN0cm95IGFuIG9iamVjdCBpcyBhbHdheXMg
dGhlIHByaXZpbGVnZSBvZgotICAgdGhlIG93bmVyIG9ubHkuCisgICB0aGUgb3duZXIuICBMaWtl
IGFsbCBwcml2aWxlZ2VzLCB0aGF0IHJpZ2h0IGNhbiBiZSBpbmhlcml0ZWQgYnkgbWVtYmVycyBv
ZgorICAgdGhlIG93bmluZyByb2xlLgogICA8L3BhcmE+CiAKICAgPHBhcmE+Ci0tIAoyLjIxLjAK
Cg==


--=-LNN3UlfuEURHgHPgxO7Q--