Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLfxJ-006nnb-0t for pgsql-docs@arkaria.postgresql.org; Wed, 19 Nov 2025 11:02:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vLfxH-00CIQn-2u for pgsql-docs@arkaria.postgresql.org; Wed, 19 Nov 2025 11:02:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLfxH-00CIQc-0o for pgsql-docs@lists.postgresql.org; Wed, 19 Nov 2025 11:02:31 +0000 Received: from fhigh-b6-smtp.messagingengine.com ([202.12.124.157]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLfxE-000LWu-2P for pgsql-docs@lists.postgresql.org; Wed, 19 Nov 2025 11:02:31 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 67EB27A00BC; Wed, 19 Nov 2025 06:02:25 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Wed, 19 Nov 2025 06:02:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1763550145; x=1763636545; bh=w7w/BhpvLPwh5xg5qQm5q7XsJndSFgBx NYdA4akE8xE=; b=KvfRYE/8mU3Mh12u7aDubZfIZdC74TIZ/Rw1eqz69jR8c0Km TCajeR32IC6TpKRtpLV1K2hamQdMwgkNzCW6MixQnlCq39UtusLxbiBBHakgNKx/ 5FhtNtqXQy3ACd67nX204kR7FDvgMR/tDsAbXqeAhvXfM4p/IybO+RJRKqSPWraw Dljfs53jfPZryj1egc9Z85MSHLiY1PE0zbWKitGk7e8c0baSsZ9eWa0fNugCZlXP g/uVy3V2xT2hEN5RIjeJc99WtBIETkH+NPYlFhAp4tFp1cv0U7tdWeQCz6eedDkF hb455DvjI4E7tv379gELAtYckQcwXboF+6rmnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1763550145; x= 1763636545; bh=w7w/BhpvLPwh5xg5qQm5q7XsJndSFgBxNYdA4akE8xE=; b=d US2KYq2r7cKSSAVhwjwr/UJN4PLuESYPRIssKVlRwP7qhWbKv15eSXUBQPTSM0sP inPWLMiYQ3OaXVa9f31iUyXeno74rXrnV7143L8GxaG0dA7MjYyKpNX8688voUzJ O7bzRJAVxn9pxTrQ9byM4wjrU8Z5zXUBX3zega6IGa88ZUCUyg7V1rriI35Nhf/A K27lS57YRt7CAE0Vk5c/1K6Cakq9qAy0nevDGsyh9EoKbU16jHYfJam/S1/xu4Yy RKlFosSARHQLjcWYPqIJl/9ivTPHOgKNHr8J0pPaAZdvjIzAPGHjY/2P9OF/sHlN yoEap8jm92irfkoavoyag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvvdegtdefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqne cuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfeileehteeljeeghfeuledthfeutedv ffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegurghnihgvlheshigvshhqlh drshgvpdhrtghpthhtohepohdrshhisghirhihrghkohhvsehpohhsthhgrhgvshhprhho rdhruhdprhgtphhtthhopehpghhsqhhlqdguohgtsheslhhishhtshdrphhoshhtghhrvg hsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Nov 2025 06:02:24 -0500 (EST) Message-ID: Date: Wed, 19 Nov 2025 12:02:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Documentation improvement patch To: Daniel Gustafsson Cc: Oleg , pgsql-docs@lists.postgresql.org References: <3881A97B-0146-4389-9C39-3C596536750B@yesql.se> <84E4E3E6-D702-4604-AE0B-AF92B80B3833@yesql.se> <284a26c6-0a38-47ab-bd73-e28943029046@postgrespro.ru> <6de77026-b34f-4f32-a0f3-2dc345c4b1bf@eisentraut.org> <93538952-E9CC-492C-9BDD-9249AD4C6B91@yesql.se> Content-Language: de-DE, en-US From: Peter Eisentraut In-Reply-To: <93538952-E9CC-492C-9BDD-9249AD4C6B91@yesql.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 14.11.25 10:04, Daniel Gustafsson wrote: >> On 30 Oct 2025, at 11:15, Peter Eisentraut wrote: > >> - Change the definition of a replication slot. >> + Changes the definition of a replication slot. >> >> I think these are intentionally written in imperative style. Compare the synopses of the main SQL commands: "change the definition of a domain" etc. > > I agree, I too think these are intentionally written like this. The document > isn't entirely consistent and does mix style quite a bit but I don't think > these changes change the needle enough to make. The following changes are left in your patch that should not be changed per the above discussion (all in doc/src/sgml/protocol.sgml): - Create a physical or logical replication + Creates a physical or logical replication - Instructs server to start streaming WAL, starting at + Instructs the server to start streaming WAL, starting at - Instructs server to start streaming WAL for logical replication, + Instructs the server to start streaming WAL for logical replication, Separately, maybe this could be improved further: - Sets the maximum number of open files each server subprocess is + Sets the maximum number of files each server subprocess is allowed to open simultaneously; files already opened in the I think it would be more correct to say something like "... number of files each server subprocess is allowed to have open simultaneously ..." (not how many open actions are happening concurrently).