Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDpVA-0008Ow-2F for pgsql-hackers@arkaria.postgresql.org; Sun, 21 Feb 2021 14:14:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lDpV8-000056-MD for pgsql-hackers@arkaria.postgresql.org; Sun, 21 Feb 2021 14:14:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDpV8-0008WC-6C for pgsql-hackers@lists.postgresql.org; Sun, 21 Feb 2021 14:14:22 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDpV4-00084V-HL for pgsql-hackers@lists.postgresql.org; Sun, 21 Feb 2021 14:14:21 +0000 Received: from [172.16.255.146] (14.149.88.79.rev.sfr.net [79.88.149.14]) (Authenticated sender: vik@postgresfriends.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 394BA240005; Sun, 21 Feb 2021 14:14:13 +0000 (UTC) Subject: Re: GROUP BY DISTINCT To: er@xs4all.nl, PostgreSQL Hackers References: <2056725465.229405.1613916363889@webmailclassic.xs4all.nl> From: Vik Fearing Message-ID: Date: Sun, 21 Feb 2021 15:14:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2056725465.229405.1613916363889@webmailclassic.xs4all.nl> Content-Type: multipart/mixed; boundary="------------79C9C420AA62EF0C5FAF14BE" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------79C9C420AA62EF0C5FAF14BE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2/21/21 3:06 PM, er@xs4all.nl wrote: >> On 2021.02.21. 13:52 Vik Fearing wrote: >> >> Attached is a patch to implement this for PostgreSQL. >> [] > > The changed line that gets stuffed into sql_features is missing a terminal value (to fill the 'comments' column). > This line: > '+T434 GROUP BY DISTINCT YES' > > (A tab at the end will do, I suppose; that's how I fixed the patch locally) Argh. Fixed. Thank you for looking at it! -- Vik Fearing --------------79C9C420AA62EF0C5FAF14BE Content-Type: text/x-patch; charset=UTF-8; name="0001-implement-GROUP-BY-DISTINCT.v02.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-implement-GROUP-BY-DISTINCT.v02.patch"