Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f8jl7-0007UP-B9 for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Apr 2018 09:52:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f8jl6-00050M-BO for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Apr 2018 09:52:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f8jl6-00050B-2g for pgsql-hackers@lists.postgresql.org; Wed, 18 Apr 2018 09:52:12 +0000 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f8jl3-0002Wr-76 for pgsql-hackers@postgresql.org; Wed, 18 Apr 2018 09:52:11 +0000 Received: by mail-qk0-x22a.google.com with SMTP id d74so1093553qkg.4 for ; Wed, 18 Apr 2018 02:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f6fwB0Tl00lXZjhoPe/xosjWUenIVQgJORYOozA/mJ0=; b=Nw1I+VyF2xArvFkIrqYArBNQ6ZKbPL0trbMP/nOiUTdzxFpEE+ClpMsS1XewRiwyj4 BO4XP+LqlKMBuam+hgN9PZpuLMymnssCPQ4YoO0qDIzna+NZXExeQQV+tSzlq2nWY15R zeeUtPZns5IEY4bCMAyg1qyhDmd2SWXLccEVwl8CHoEyy9bLcmgxnjkpJrLRVuppcjSQ NYe/wNAPFDbxI8e6YOs1Y0MGJJXjVP3mH+/XPLxg83xkaZ4EYmZOXMYFttCXMi2FKfjl D/Xo2nYHQVTqlCXm/m7U3mzfxC7BPid+TCxgD88098+EnFHcdUEwMQhg72yiM/4gbWHO 2BKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f6fwB0Tl00lXZjhoPe/xosjWUenIVQgJORYOozA/mJ0=; b=f8l03nFKoSVuBYudshJ95HCcBPJYwGM1ol5T69CAcHPMhZLxCfAsrkSyMFLrhe3p6A 21PprviiU6bKnzlXk7jtvhNA0gANnLrNowPjNUsPcG69H7SPDfmW0VHqiNGjUzoX7Ag8 rQglDs9alc80/QGAfs2yVP7z5CPk+6WdzgT+ImZDXPtp4vK8Qgaly6q1t/BUkrvowrP7 7LAGlQxu8gY2aj4G+VK5T36oJNrhlHnjP9cRV2g0f4DtyAgqAioIDaxpdLWH8wHdXDPZ lPrjFW4OuHCDfsSWJzaZA5mMrJJr0paH14MTS36zzDi++JcV+L6nlsKw/JjEp/R13zUg ufXA== X-Gm-Message-State: ALQs6tC44cSDU7X7oEM7DZn6YlqTDTgOszgOD5smrkn6Z3UnBShlPieX /3TaVMUPJeoEOGSUG6BwnSA+0w== X-Google-Smtp-Source: AB8JxZrjayiB3vmubvXblVwZe6MsanByRiBsU2qx8YhLqurHjsrLajtTfO3wj/WQ8SjsNeVEn2dryA== X-Received: by 10.55.131.1 with SMTP id f1mr1245582qkd.400.1524045126499; Wed, 18 Apr 2018 02:52:06 -0700 (PDT) Received: from [10.10.30.114] ([208.123.164.34]) by smtp.gmail.com with ESMTPSA id i82sm574294qke.44.2018.04.18.02.52.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Apr 2018 02:52:05 -0700 (PDT) Sender: Heikki Linnakangas Subject: Re: Fix for documentation of Covering Indexes To: Michael Paquier , Postgres hackers References: <20180411082020.GD19732@paquier.xyz> From: Heikki Linnakangas Message-ID: Date: Wed, 18 Apr 2018 05:52:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180411082020.GD19732@paquier.xyz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 11/04/18 04:20, Michael Paquier wrote: > Hi all, > > The documentation of covering indexes is incorrect for CREATE and ALTER > TABLE: > - ALTER TABLE's page is missing the call. > - Exclusion constraints can use INCLUDE clauses. > > In order to simplify the documentation, please let me suggest the > attached which moves the definition of the INCLUDE clause into the > section index_parameters, which is compatible with what I read from the > parser. Committed, thanks! - Heikki