Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvcZG-0003kW-4Y for pgsql-docs@arkaria.postgresql.org; Wed, 05 Apr 2017 04:29:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cvcZF-0003yw-Kk for pgsql-docs@arkaria.postgresql.org; Wed, 05 Apr 2017 04:29:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cvcYs-0003JE-NM for pgsql-docs@postgresql.org; Wed, 05 Apr 2017 04:28:50 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cvcYq-0001PB-5D for pgsql-docs@postgresql.org; Wed, 05 Apr 2017 04:28:49 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8112720AF9; Wed, 5 Apr 2017 00:28:47 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Wed, 05 Apr 2017 00:28:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=duZzDz5i569K7dlFyUo9Nqc096TFMvUf8C3+IURfcJI=; b=aJ5lECO5 MjmRJNOD7JszC5XbIeYmWsa6DIiyMVazMkg4/L2HqeAo1eibaW1TqHkRyyoftR2b zTSzXwp/ouQl7/ixxfnXfqTug6PT8b7H30lEakgAllYFRlpJHYp2CZAXL4OklL3g WV2EkZ3yaicHjRLupaNmdBF9p0UTlITFuIUq0ouZhYFvdioDUPRTQP7uC8os9Yir aXcGeaz/pP9uHCouMHZKl+utcGHRraMLICmQtXMEQzEpAsIUIL031LwvigYhoLmg bC4YnvsWN+OOY+LXWo9RJ445w1pyp7tippIcAnZmvzeB/d3sPYehdSZej0JHQZ57 tA76aj/UDl9Ljw== X-ME-Sender: X-Sasl-enc: /XAqrk/AIseTy2WKnIMuBrkbvljpBXtb9bga6fEQYvpu 1491366527 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 366C47E442; Wed, 5 Apr 2017 00:28:47 -0400 (EDT) Subject: Re: Misleading To: marek.cvoren@gmail.com, pgsql-docs@postgresql.org References: <20170328110253.2695.62609@wrigleys.postgresql.org> From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Wed, 5 Apr 2017 00:28:46 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170328110253.2695.62609@wrigleys.postgresql.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org On 3/28/17 07:02, marek.cvoren@gmail.com wrote: > Please correct following part of pg_upgrade documentation: > `You can also specify user and port values, and whether you want the data > linked instead of copied (the default).` > > It is not clear what is the default option. If you read the whole sentence, > then context might be misinterpreted to `data linked instead of copied` is > default but you meant that copying is default. Please correct this as it is > confusing and can lead someone to big troubles. > > My suggestion: > - completely omit confusing default word: > `You can also specify user and port values, and whether you want the data > linked instead of copied.` It's debatable whether that sentence is unclear, I think, but the change you propose actually loses the information about what mode is the default, which wouldn't be good. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs