Message-ID: <d3dcd30164a4f86588d33013e3bd41d7f576f17f.camel@cybertec.at>
Subject: Re: Version 14/15 documentation Section "Alter Default Privileges"
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Bruce Momjian <bruce@momjian.us>
Cc: Michael Banck <mbanck@gmx.net>, David Burns <david.burns@fedex.com>,
	pgsql-hackers@lists.postgresql.org
Date: Wed, 08 Nov 2023 13:12:24 +0100
In-Reply-To: <ZUq6fAsQZsyUAySx@momjian.us>
References: <7de5f33f49a91d7b30b8c01fe46fc280713ebae1.camel@cybertec.at>
	 <653cce08.050a0220.a10fb.7878@mx.google.com> <ZUUlmpxzsZMSZ7N_@momjian.us>
	 <b227432f87266b680fd6f31e37b202b2fae5d9b6.camel@cybertec.at>
	 <ZUaLgyKdfWeh6nlj@momjian.us>
	 <244e0f9e3300f165ff578302e942fa3145dedfc7.camel@cybertec.at>
	 <ZUbsWcPypVORlYCg@momjian.us>
	 <ceac8e2df89a5eb1335ad8ce39c6ba0beaeddde3.camel@cybertec.at>
	 <ZUkMi9UhnfHyIQMf@momjian.us>
	 <06bdd234afabd3144ffaf8e95f42af0f3b38082e.camel@cybertec.at>
	 <ZUq6fAsQZsyUAySx@momjian.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/d3dcd30164a4f86588d33013e3bd41d7f576f17f.camel%40cybertec.at>
Precedence: bulk

On Tue, 2023-11-07 at 17:30 -0500, Bruce Momjian wrote:
> You didn't seem to like my SET ROLE suggestion so I removed it.

I thought that the information that you can use SET ROLE to assume
the identity of another role is correct, but leads a bit too far
in the manual page of ALTER DEFAULT PRIVILEGES.

> > +  <para>
> > +   There is no way to change the default privileges for objects create=
d by
> > +   arbitrary roles.  You have run <command>ALTER DEFAULT PRIVILEGES</c=
ommand>
>=20
> I find the above sentence odd.  What is its purpose?

I cannot count how many times I have seen the complaint "I have run ALTER D=
EFAULT
PRIVILEGES, and now when some other user creates a table, the permissions a=
re
unchanged". People tend to think that if you omit FOR ROLE, the change appl=
ies to
PUBLIC.

Your improved documentation of "target_role" already covers that somewhat, =
so if
you don't like the repetition, I'm alright with that.  I just thought it mi=
ght
be worth stating it explicitly.

I think your patch is fine and ready to go.

Yours,
Laurenz Albe
>=20