Message-ID: <d7d7aa84-d0be-436b-8ebe-2f7db22f1196@oss.nttdata.com>
Date: Sun, 20 Jul 2025 12:09:49 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Document reopen of output file via SIGHUP in pg_recvlogical
Content-Language: en-US
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
References: <0977fc4f-1523-4ecd-8a0e-391af4976367@oss.nttdata.com>
 <CAOzEurQ9fZKw+Ydr2=LUBr=XCmXzjA+u=xmKjj=7bA=BGNharA@mail.gmail.com>
 <29fd8017-7f4a-4d58-8649-4847c558c8a7@oss.nttdata.com>
 <CAOzEurTqyHzLWq9JKu21sqU=nkx3oMtf5xATsz9-G3LhmDePjA@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <CAOzEurTqyHzLWq9JKu21sqU=nkx3oMtf5xATsz9-G3LhmDePjA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/d7d7aa84-d0be-436b-8ebe-2f7db22f1196%40oss.nttdata.com>
Precedence: bulk


On 2025/07/18 16:15, Shinya Kato wrote:
> On Fri, Jul 18, 2025 at 12:33 PM Fujii Masao
> <masao.fujii@oss.nttdata.com> wrote:
>>
>>
>>
>> On 2025/07/18 11:35, Shinya Kato wrote:
>>> On Thu, Jul 10, 2025 at 4:48 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> pg_recvlogical continuously writes to the file specified with the --file option,
>>>> which means the output file can grow indefinitely. To manage file size,
>>>> some users may want to rotate the output periodically.
>>>>
>>>> While reviewing the source code to find the way to rotate the file, I noticed
>>>> that pg_recvlogical reopens the output file when it receives a SIGHUP signal.
>>>> This makes file rotation possible: we can rename the current output file and
>>>> then send a SIGHUP to pg_recvlogical, which will close the renamed file and
>>>> open a new one with the same original name.
>>>>
>>>> This is a useful feature, but it's currently undocumented. So I'd like to
>>>> apply the attached patch that adds this information to the documentation.
>>>> Thought?
>>>
>>> Agreed.
>>> I have confirmed the behavior and I think it should be documented.
>>>
>>> Your patch looks good, except that you should use "specified by"
>>> instead of "given with" to be consistent with the other documents.
>>
>> Thanks for the review! I've updated the patch as suggested.
>> The revised version is attached.
>>
>> Unless there are any objections, I will commit and back-patch it to v13.
>>
>> Regards,
>>
>> --
>> Fujii Masao
>> NTT DATA Japan Corporation
> 
> Thanks for updating the patch. LGTM.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation