Date: Mon, 29 Jul 2024 14:56:05 +0200
From: Erik Wienhold <ewie@ewie.name>
To: elionescu@yahoo.com, pgsql-docs@lists.postgresql.org
Subject: Re: incorrect (incomplete) description for "alter domain"
Message-ID: <e0e8271f-687d-4eef-bce0-b706165930b0@ewie.name>
References: <172225092461.915373.6103973717483380183@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <172225092461.915373.6103973717483380183@wrigleys.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/e0e8271f-687d-4eef-bce0-b706165930b0%40ewie.name>
Precedence: bulk

On 2024-07-29 13:02 +0200, PG Doc comments form wrote:
> In the Synopsis section of
> https://www.postgresql.org/docs/current/sql-alterdomain.html
> this is incorrect (incomplete):
> "ALTER DOMAIN name ADD domain_constraint [ NOT VALID ]"
> It should be 
> "ALTER DOMAIN name ADD CONSTRAINT domain_constraint [ NOT VALID ]"

No, the docs are correct.  domain_constraint refers to this syntax
defined by CREATE DOMAIN:

    "where constraint is:

    [ CONSTRAINT constraint_name ]
    { NOT NULL | NULL | CHECK (expression) }"

Also, PG 17 renames this to "domain_constraint" with commit 9895b35cb8
to align ALTER DOMAIN with CREATE DOMAIN.

-- 
Erik