Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljmye-0001Rw-Sw for pgsql-docs@arkaria.postgresql.org; Thu, 20 May 2021 18:00:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ljmyc-0006ZY-AC for pgsql-docs@arkaria.postgresql.org; Thu, 20 May 2021 18:00:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljmyc-0006ZQ-2d for pgsql-docs@lists.postgresql.org; Thu, 20 May 2021 18:00:54 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ljmyU-0004Zs-Sh for pgsql-docs@lists.postgresql.org; Thu, 20 May 2021 18:00:53 +0000 Received: from [10.0.1.8] (unknown [188.123.231.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 9A42D21C618E for ; Thu, 20 May 2021 21:00:45 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1621533645; bh=Q4cosVEqpDf6MNX9zV2qmjnp6DTpVdXdqvWbYyGhDE0=; h=Subject:From:To:References:Date:In-Reply-To; b=m32Lr5dOW88yqw41Ts7PcqLL23a4LhWkNebb56G6g5E1ADYSOy+S5f84l/hHVprTo E/LiLitYeQGKB6mKaLZClpg++w6JTfDz9OCYAya9gK5jNfTPVj+B0KmS9yd7V4QtuK 5ER+0mUxivJO7gyxZvecUUhHmLoqENaU1sQ9jcTU= Subject: Re: pg_monitor role description From: Pavel Luzanov To: pgsql-docs@lists.postgresql.org References: <162149110071.26171.15811576640435665698@wrigleys.postgresql.org> <7018bb3a-26f1-a9be-1659-3bdafd122669@postgrespro.ru> <3690478.1621526623@sss.pgh.pa.us> <5692728c-f0f3-c888-e5e9-19efd4051198@postgrespro.ru> Message-ID: Date: Thu, 20 May 2021 21:00:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <5692728c-f0f3-c888-e5e9-19efd4051198@postgrespro.ru> Content-Type: multipart/mixed; boundary="------------5DB0DA284C98EFCAC61DBE9E" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------5DB0DA284C98EFCAC61DBE9E Content-Type: multipart/alternative; boundary="------------E067FA059C4CAFBC48251DAC" --------------E067FA059C4CAFBC48251DAC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, On 20.05.2021 20:27, Pavel Luzanov wrote: > So, is it correct to change description of pg_monitor role from: > "Read/execute various monitoring views and functions. This role is a member of|pg_read_all_settings|,|pg_read_all_stats| and|pg_stat_scan_tables|." > to > "Read/execute various monitoring views and functions. The roles pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables are members of this role." > > I can prepare a simple patch. Just in case, patch attached. -- Pavel Luzanov Postgres Professional: https://postgrespro.com The Russian Postgres Company --------------E067FA059C4CAFBC48251DAC Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hello,

On 20.05.2021 20:27, Pavel Luzanov wrote:
So, is it correct to change description of pg_monitor role from:
"Read/execute various monitoring views and functions. This role is a member of pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables."
to
"Read/execute various monitoring views and functions. The roles pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables are members of this role."

I can prepare a simple patch.

Just in case, patch attached.


-- 
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
--------------E067FA059C4CAFBC48251DAC-- --------------5DB0DA284C98EFCAC61DBE9E Content-Type: text/x-patch; charset=UTF-8; name="doc-pg_monitor.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="doc-pg_monitor.patch" diff --git a/doc/src/sgml/user-manag.sgml b/doc/src/sgml/user-manag.sgml index fe0bdb7599..00338bbebd 100644 --- a/doc/src/sgml/user-manag.sgml +++ b/doc/src/sgml/user-manag.sgml @@ -554,9 +554,9 @@ DROP ROLE doomed_role; pg_monitor Read/execute various monitoring views and functions. - This role is a member of pg_read_all_settings, - pg_read_all_stats and - pg_stat_scan_tables. + The roles pg_read_all_settings, + pg_read_all_stats and pg_stat_scan_tables + are members of this role. pg_database_owner --------------5DB0DA284C98EFCAC61DBE9E--